Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post sharing link & Remove unused share count & Remove ts-path @config #303

Merged

Conversation

Samuel-Therrien-Beslogic
Copy link
Contributor

@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic commented Nov 22, 2024

  • The project passes automated tests (build, linting, etc.).
  • You updated the project's documentation with new changes.
  • You've linked any issue this PR closes
  • You reviewed your own PR and made sure there's no test/debug code or any obvious mistakes.

Make sure that the code wasn't copied from elsewhere (check one):

  • This is your own original code
  • You have made sure that we have permission to use the copied code and that we follow its licensing

Removing canopeum_frontend/src/config/ and moving out apiSchemaGenerator.js caused a chain of necessary changes.
This otherwise just removes an unused feature from the frontend. Comment it out in the backend, and fixes links.

image

The migration created by this PR is optional (not running it should cause code to still work, just have an unused data being passed around), so I'm not concerned about having to run it on prod before the demo

@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic changed the title WIP Fix post sharing link and unused share count Fix post sharing link and unused share count & Remove ts-path @config Nov 26, 2024
@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic changed the title Fix post sharing link and unused share count & Remove ts-path @config Fix post sharing link & Remove unused share count & Remove ts-path @config Nov 26, 2024
@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic marked this pull request as ready for review November 26, 2024 19:12
@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic merged commit c735c7b into main Nov 26, 2024
6 checks passed
@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic deleted the FIx-post-sharing-link-and-unused-share-count branch November 26, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant