2024-11-17 deployment

.github/workflows/canopeum_backend_pr_validation.yml

@@ -63,3 +63,35 @@ jobs:
           version: PATH
           python-version: "3.12"
           working-directory: canopeum_backend
+
+  Ruff-Autofixes:
+    runs-on: unbuntu-latest
+    defaults:
+      run:
+        working-directory: canopeum_backend
+    # Only run autofixes on PRs
+    if: ${{ github.event_name == 'pull_request' }}
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          repository: ${{ github.event.pull_request.head.repo.full_name }}
+          ref: ${{ github.event.pull_request.head.ref }}
+          # Token with Contents permissions to allow retriggering workflow
+          token: ${{ secrets.PR_AUTOFIX_PAT }}
+      - run: echo "${{github.event.head_commit.author.name}}"
+      - uses: astral-sh/ruff-action@v1
+        with:
+          args: check --fix
+      - uses: astral-sh/ruff-action@v1
+        # Format even on lint failure
+        if: ${{ !cancelled() }}
+        with:
+          args: format
+      - name: Commit autofixes
+        uses: EndBug/add-and-commit@v9
+        # TODO: Prevent infinite loops, github.event.head_commit.author.name is not accessible in this context
+        # if: ${{ github.event.head_commit.author.name != 'github-actions' }}
+        # Push autofixes even on failure
+        if: ${{ !cancelled() }}
+        with:
+          default_author: github_actions

.github/workflows/canopeum_frontend_pr_validation.yml

@@ -16,16 +16,32 @@ on:
       - ".github/workflows/canopeum_frontend_pr_validation.yml"
 
 jobs:
-  Lint:
+  Lint-Autofixes:
     runs-on: ubuntu-latest
     defaults:
       run:
         working-directory: canopeum_frontend
+    # Only run autofixes on PRs
+    if: ${{ github.event_name == 'pull_request' }}
     steps:
       - uses: actions/checkout@v4
+        with:
+          repository: ${{ github.event.pull_request.head.repo.full_name }}
+          ref: ${{ github.event.pull_request.head.ref }}
+          # Token with Contents permissions to allow retriggering workflow
+          token: ${{ secrets.PR_AUTOFIX_PAT }}
       - uses: actions/setup-node@v4
       - run: npm ci
-      - run: npm run lint
+      - run: npm run lint:fix
+      - name: Commit autofixes
+        uses: EndBug/add-and-commit@v9
+        # TODO: Prevent infinite loops, github.event.head_commit.author.name is not accessible in this context
+        # if: ${{ github.event.head_commit.author.name != 'github-actions' }}
+        # Push autofixes even on failure
+        if: ${{ !cancelled() }}
+        with:
+          default_author: github_actions
+
   Build:
     runs-on: ubuntu-latest
     defaults:

.vscode/extensions.json

@@ -22,6 +22,8 @@
     "dbaeumer.vscode-eslint",
     "dprint.dprint",
     "meganrogge.template-string-converter",
+    "mrmlnc.vscode-scss",
+    "sibiraj-s.vscode-scss-formatter", // This can likely eventually be replaced by dprint's malva plugin
     // Python/TOML
     "charliermarsh.ruff",
     "ms-python.mypy-type-checker",

.vscode/settings.json

@@ -143,7 +143,7 @@
     "editor.defaultFormatter": "vscode.css-language-features"
   },
   "[scss]": {
-    "editor.defaultFormatter": "vscode.css-language-features"
+    "editor.defaultFormatter": "sibiraj-s.vscode-scss-formatter"
   },
   "[postcss]": {
     "editor.defaultFormatter": "vscode.css-language-features"
@@ -154,6 +154,9 @@
   "less.format.spaceAroundSelectorSeparator": true,
   "css.format.spaceAroundSelectorSeparator": true,
   "scss.format.spaceAroundSelectorSeparator": true,
+  "scssFormatter.printWidth": 100,
+  "scssFormatter.singleQuote": true,
+  "scssFormatter.trailingComma": "all",
 
   /*
   * Python

README.md

@@ -104,12 +104,6 @@ For backend
    uv run ./scripts/checkers.py
    ```
 
-   For both: (autofixers)
-
-   ```shell
-   pre-commit run --all
-   ```
-
 ### Quickly running the application locally
 
 We've made a `start-local-env.ps1` helper script to ease starting up the application. Feel free to use and improve it.