Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor "Site Manager" to "Forest Steward" to match business design #277

Conversation

Samuel-Therrien-Beslogic
Copy link
Contributor

@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic commented Oct 29, 2024

  • The project passes automated tests (build, linting, etc.).
  • You updated the project's documentation with new changes.
  • You've linked any issue this PR closes
  • You reviewed your own PR and made sure there's no test/debug code or any obvious mistakes.

Make sure that the code wasn't copied from elsewhere (check one):

  • This is your own original code
  • You have made sure that we have permission to use the copied code and that we follow its licensing

Closes #238
This also improves the use of StrEnums in Python

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the other project should we just consider redoing the db and handle migration later?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been squashing the migrations and nuking the DB out of lazyness/simplicity when it would require doing a manual migration script.

These should work just fine as is

@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic merged commit 8921051 into main Nov 14, 2024
6 checks passed
@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic deleted the refactor/238-Change-SiteManager-role-name-to-ForestSteward branch November 14, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change SiteManager role name to ForestSteward
2 participants