Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically calculate total number of plants and seeds #274

Merged
merged 10 commits into from
Nov 14, 2024
Merged

Automatically calculate total number of plants and seeds #274

merged 10 commits into from
Nov 14, 2024

Conversation

Samuel-Therrien-Beslogic
Copy link
Contributor

@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic commented Oct 29, 2024 •
edited
Loading

  • The project passes automated tests (build, linting, etc.).
  • You updated the project's documentation with new changes.
  • You've linked any issue this PR closes
  • You reviewed your own PR and made sure there's no test/debug code or any obvious mistakes.

Make sure that the code wasn't copied from elsewhere (check one):

  • This is your own original code
  • You have made sure that we have permission to use the copied code and that we follow its licensing

Closes #241
autocalculated

pre-commit-ci bot and others added 7 commits October 29, 2024 19:36
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
5072e5d 
for more information, see https://pre-commit.ci
@Samuel-Therrien-Beslogic
Add migration
ff99ee6
@Samuel-Therrien-Beslogic
Merge branch 'feature/241-Total-number-of-plants-should-be-calculated…
4cbae93 
…-automatically' of https://github.com/BesLogic/releaf-canopeum into feature/241-Total-number-of-plants-should-be-calculated-automatically
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
9f82046 
for more information, see https://pre-commit.ci
@Samuel-Therrien-Beslogic
DOn't inline disable total-functions/no-unsafe-type-assertion
a1c7352
@Samuel-Therrien-Beslogic
Merge branch 'feature/241-Total-number-of-plants-should-be-calculated…
bc05004 
…-automatically' of https://github.com/BesLogic/releaf-canopeum into feature/241-Total-number-of-plants-should-be-calculated-automatically
@Samuel-Therrien-Beslogic
Get actual survived_count and propagation_count in SiteSummarySeriali…
db3f73f 
…zer and SiteSummaryDetailSerializer
andy2great
andy2great reviewed Nov 11, 2024
View reviewed changes
canopeum_backend/canopeum_backend/migrations/0002_remove_batch_total_number_seed.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we beware of the migration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This migration should work as-is. No loss of data because now its calculated.
django also tells you when you have migrations to run

@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic merged commit 85ab12c into main Nov 14, 2024
6 checks passed
@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic deleted the feature/241-Total-number-of-plants-should-be-calculated-automatically branch November 14, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy2great andy2great andy2great left review comments

@theo-auffeuvre theo-auffeuvre Awaiting requested review from theo-auffeuvre theo-auffeuvre is a code owner

@BesOlivierBouchard BesOlivierBouchard Awaiting requested review from BesOlivierBouchard BesOlivierBouchard is a code owner

@NicolasDontigny NicolasDontigny Awaiting requested review from NicolasDontigny NicolasDontigny is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Total number of plants should be calculated automatically
2 participants
@Samuel-Therrien-Beslogic @andy2great