Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render icon per site type #271

Conversation

Samuel-Therrien-Beslogic
Copy link
Contributor

@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic commented Oct 24, 2024

  • The project passes automated tests (build, linting, etc.).
  • You updated the project's documentation with new changes.
  • You've linked any issue this PR closes
  • You reviewed your own PR and made sure there's no test/debug code or any obvious mistakes.

Make sure that the code wasn't copied from elsewhere (check one):

  • This is your own original code
  • You have made sure that we have permission to use the copied code and that we follow its licensing

Closes #269

As mentioned in #270,

https://www.npmjs.com/package/material-icons does not support custom icons.
Since we already use https://www.npmjs.com/package/@mui/material, we could consider https://www.npmjs.com/package/@mui/icons-material .

For the short term, we're using incorrect, but still unique, icons for "Canopeum" and "Farms Land".

I am still annoyed at "Site Type" living in the database as this forces us to ensure they're generated with the proper IDs. Adding/removing a site type or updating its icon still requires a re-deployment anyway since this isn't something that can be changed by an application user (maybe if we start using the Django Admin Panel? but even then, the custom icon asset and fixed IDs will still be issues)

@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic force-pushed the feature/269-As-a-User,-I-want-to-see-different-pins-per-site-type branch from a9d3e3d to c84a0fb Compare October 24, 2024 18:45
@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic merged commit 5ed7e6d into main Nov 12, 2024
6 checks passed
@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic deleted the feature/269-As-a-User,-I-want-to-see-different-pins-per-site-type branch November 12, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a User, I want to see different pins and icons per site type
1 participant