Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for missing migration #256

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Check for missing migration #256

merged 1 commit into from
Oct 3, 2024

Conversation

Samuel-Therrien-Beslogic
Copy link
Contributor

Closes #252

  • Add a CI job to run django tests (which uses unittest by default with automatic test discovery)
  • This test creates a dummy DB to test migration against. Check if a new migration would be created from model changes, if so: fail
  • Renamed PR validation actions

@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic force-pushed the 252-Add-a-CI-check-that-no-django-migrations-need-to-be-created branch from 4da28d3 to 5a87cb2 Compare October 1, 2024 17:45
@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic enabled auto-merge (squash) October 1, 2024 17:45
@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic mentioned this pull request Oct 1, 2024
Merged
@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic merged commit be57ef0 into main Oct 3, 2024
6 checks passed
@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic deleted the 252-Add-a-CI-check-that-no-django-migrations-need-to-be-created branch October 3, 2024 18:02
andy2great pushed a commit that referenced this pull request Oct 10, 2024
@Samuel-Therrien-Beslogic @Andrew-Beslogic
Check for missing migration (#256)
8bf6643
andy2great pushed a commit that referenced this pull request Oct 10, 2024
@Samuel-Therrien-Beslogic @andy2great
Check for missing migration (#256)
c5d4a2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felix029 felix029 felix029 approved these changes

@theo-auffeuvre theo-auffeuvre Awaiting requested review from theo-auffeuvre theo-auffeuvre is a code owner

@BesOlivierBouchard BesOlivierBouchard Awaiting requested review from BesOlivierBouchard BesOlivierBouchard is a code owner

@NicolasDontigny NicolasDontigny Awaiting requested review from NicolasDontigny NicolasDontigny is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a CI check that no django migrations need to be created
2 participants
@Samuel-Therrien-Beslogic @felix029