Skip to content
Frontend PR validation

Bump eslint-config-beslogic to 3.0 and drop-pre-commit #21

Sign in to view logs

Bump eslint-config-beslogic to 3.0 and drop-pre-commit

Bump eslint-config-beslogic to 3.0 and drop-pre-commit #21

Triggered via pull request October 10, 2024 19:06
@Samuel-Therrien-BeslogicSamuel-Therrien-Beslogic
synchronize #268
Bump-eslint-config-beslogic-to-3.0.0
Status Failure
Total duration 1m 54s
Artifacts –

canopeum_frontend_pr_validation.yml

on: pull_request
Lint
1m 6s
Lint
Build
1m 45s
Build
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 8 warnings
Lint: canopeum_frontend/src/components/analytics/OptionQuantitySelector.tsx#L46
Prefer `!== -1` over `>= 0` to check existence
Lint
Process completed with exit code 1.
Lint: canopeum_frontend/src/components/analytics/BatchTable.tsx#L30
Unexpected 'TODO' comment: 'TODO: Use endpoint to get specific batch...'
Lint: canopeum_frontend/src/components/icons/CustomIcon.tsx#L23
Unexpected 'TODO' comment: 'TODO(NicolasDontigny): Find the best way...'
Lint: canopeum_frontend/src/components/inputs/MultipleSelectChip.tsx#L68
Unexpected 'TODO' comment: 'TODO(NicolasDontigny): Find a more...'
Lint: canopeum_frontend/src/hooks/HttpHook.tsx#L24
Unexpected 'TODO' comment: 'TODO(NicolasDontigny): Instead of...'
Lint: canopeum_frontend/src/main.tsx#L9
Unexpected 'TODO' comment: 'TODO: Ask Nicolas if these were...'
Lint: canopeum_frontend/src/pages/SiteSocialPage.tsx#L151
Always prefer const x: T = { ... }
Lint: canopeum_frontend/src/pages/SiteSocialPage.tsx#L156
Always prefer const x: T = { ... }
Lint: canopeum_frontend/src/services/apiSettings.ts#L1
Unsafe assignment of an `any` value