Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternative method for drawing multiple cards #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juanpescador
Copy link

Also add detail about how to use the alternative methods and links to two other resources on advanced controls.

Also add detail about how to use the alternative methods and links to two other resources on advanced controls.
@Knils
Copy link
Contributor

Knils commented Jan 31, 2021

Hey we aren't using the old berserk-games knowledge base anymore.

@juanpescador
Copy link
Author

I don't understand what you mean, should this PR go somewhere else? Have a link? I can see other PRs were merged recently.

@corlick98
Copy link

You have links to the old knowledgebase and I believe they are trying to keep everything contained to kb.tabletopsimulator.com. A link to the video tutorial for advanced controls is a good idea in my opinion, maybe moving it to the top as I feel a see also section with one link doesn't look very nice.
Better capitalization would also be appreciated (Alt + Rotate instead of Alt + rotate).
If you are only capitalizing the first letter of Alt then that formatting should extend to the rest of the page too. It should also be decided if Shift should be written in Title Case or all caps as currently 3 are all caps and 2 are title case.

@juanpescador
Copy link
Author

You have links to the old knowledgebase and I believe they are trying to keep everything contained to kb.tabletopsimulator.com.

Ah, that's a pity. I think linking to other existing resources is valuable.

Better capitalization would also be appreciated (Alt + Rotate instead of Alt + rotate).
If you are only capitalizing the first letter of Alt then that formatting should extend to the rest of the page too. It should also be decided if Shift should be written in Title Case or all caps as currently 3 are all caps and 2 are title case.

Good point, but in the opposite direction for me, I'd normalise the other headings to sentence case. The common approach is to title-case Alt and other keyboard modifier keys (they've basically become proper nouns). Rotate isn't a proper noun, so it shouldn't be title-cased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants