Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all remaining prif interfaces #48

Merged
merged 22 commits into from
Dec 19, 2023
Merged

Add all remaining prif interfaces #48

merged 22 commits into from
Dec 19, 2023

Conversation

ktras
Copy link
Collaborator

@ktras ktras commented Dec 18, 2023

Add all remaining prif interfaces based on design doc revision 0.2

ktras added 20 commits December 15, 2023 16:40
@ktras
Rename team_type_m to teams_m, since the module contains
2c3d6fd 
more than just a definition for `team_type`, it contains interfaces
for team related statements and procedures.
@ktras
Add interfaces for prif_allocate_non_symmetric, prif_deallocate,
c77cc85 
and `prif_deallocate_non_symmetric` in `allocation_m`.
@ktras
Add new module, coarray_queries_m and add interfaces for
0e2269c 
`prif_lcobound` and `prif_ucobound`
@ktras
Add interfaces for prif_coshape and prif_image_index to
ad0ca30 
`coarray_queries_m`.
@ktras
Add interfaces for the remaining synchronization statements
3bc6f53
@ktras
Add new module, locks_m, and add interfaces for prif_lock and
43782ba 
`prif_unlock`.
@ktras
Add new module, critical_m, and add interfaces for prif_critical
667a2e4 
and `prif_end_critical`.
@ktras
Add new module, events_m, and add interfaces for prif_event_post,
62dbb65 
`prif_event_wait`, and `prif_event_query`.
@ktras
Add interfaces for the remaining procedures related to teams
b422e68
@ktras
Add new module, atomic_m, and add interfaces for prif_atomic_add
3fefbf4 
and `prif_atomic_and`.
@ktras
Add interfaces for the remaining atomic procedures
8724069
@ktras
Add interface for prif_fail_image
1b5a3b7
@ktras
Rename module image_enumeration_m to image_queries_m
9ec9231
@ktras
Add interfaces for prif_failed_images and prif_stopped_images
363dee1
@ktras
Add interface for prif_image_status
aeb76a6
@ktras
Update use-stmts in prif
2dea5ca
@ktras
Update intent-spec for dummy args in critical_m.
c45da07
@ktras
Add new module, prif_queries_m, and interfaces for
238582d 
`prif_set_context_data`, `prif_get_context_data`,
`prif_base_pointer`, and `prif_local_data_size`.
@ktras
Add new module, alias_m, and interfaces for prif_alias_create
7945424 
and `prif_alias_destroy`.
@ktras
Add new module, coarray_access_m, and interfaces for prif_put,
ac94535 
`prif_put_strided`, `prif_put_raw`, `prif_put_raw_strided`,
`prif_get`, `prif_get_raw`, and `prif_get_raw_strided`.
@ktras ktras marked this pull request as ready for review December 18, 2023 19:40
bonachea
bonachea requested changes Dec 18, 2023
View reviewed changes
Copy link
Member

@bonachea bonachea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

I did NOT attempt to exhaustively compare all the subroutine signatures for spec conformance, although that's something that eventually needs to be audited, and ideally supported with test code that ensures calls compile as intended.

src/prif.f90 Show resolved Hide resolved
everythingfunctional
everythingfunctional approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@everythingfunctional everythingfunctional left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A did a brief once-over and nothing jumps out. LGTM

@ktras ktras requested a review from bonachea December 19, 2023 02:13
bonachea
bonachea approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@bonachea bonachea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing pure from functions internal to caffeine is probably overkill, but I have no specific objection.

The important part is to match the specified prif_ interfaces at the top.

@ktras
Copy link
Collaborator Author

ktras commented Dec 19, 2023

Removing pure from functions internal to caffeine is probably overkill, but I have no specific objection.

The important part is to match the specified prif_ interfaces at the top.

@bonachea, I agree. I only removed pure from functions that I had to based on the cascading affects of pure being removed from some of the prif_ interfaces that called other pure functions and no longer can. Thanks for the review!

@ktras ktras merged commit e434690 into main Dec 19, 2023
6 checks passed
@ktras ktras deleted the add-all-prif-interfaces branch December 19, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonachea bonachea bonachea approved these changes

@everythingfunctional everythingfunctional everythingfunctional approved these changes

@rouson rouson Awaiting requested review from rouson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktras @everythingfunctional @bonachea