-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test with Julienne #169
base: main
Are you sure you want to change the base?
Test with Julienne #169
Changes from 16 commits
f4cb506
7ebab05
1d87e74
d70e76c
b0354e1
b425d2f
ad8f546
435d148
ce8aa06
c2b765f
3f26d78
dec2d23
7268613
2ffdbb6
7ce33b7
3b5c974
dd3fb3a
00ae2b3
6d03002
9ae13e9
1da811b
9ab0a7f
5cc1538
9341364
a529490
277c746
b3e90e5
d70134e
e892ce2
8a74c08
fcf2fa8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ maintainer = "[email protected]" | |
copyright = "2021-2024 UC Regents" | ||
|
||
[dev-dependencies] | ||
veggies = {git = "https://gitlab.com/everythingfunctional/veggies", tag = "v1.1.3"} | ||
iso_varying_string = {git = "https://gitlab.com/everythingfunctional/iso_varying_string.git", tag = "v3.0.4"} | ||
julienne = {git = "https://github.com/berkeleylab/julienne.git", tag = "1.5.3"} | ||
assert = {git = "https://github.com/berkeleylab/assert.git", tag = "2.0.0"} | ||
|
||
[build] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
Test Termination | ||
---------------- | ||
The code in this subdirectory intentionally terminate to tests the following | ||
procedures and interface from prif.F90: | ||
- `prif_error_stop` | ||
- `prif_register_stop_callback` | ||
- `prif_stop_callback_interface` | ||
- `prif_stop` | ||
|
||
Usage | ||
----- | ||
To build or rebuild and run the tests in this subdirectory, execute the following | ||
commands: | ||
``` | ||
fpm clean --all | ||
cd .. | ||
./install.sh | ||
cd - | ||
mkdir build | ||
cp ../build/run-fpm.sh build | ||
../build/run-fpm.sh test | ||
``` | ||
which should yield trailing output similar to the following: | ||
``` | ||
ERROR STOP 'USER_PROVIDED_STRING' | ||
callback invoked | ||
STOP | ||
STOP 'USER_PROVIDED_STRING' | ||
STOP 99 | ||
STOP | ||
<ERROR> Execution for object " error_stop_with_character_code " returned exit code 1 | ||
<ERROR> Execution for object " error_stop_with_integer_code " returned exit code 100 | ||
<ERROR> Execution for object " error_stop_with_no_code " returned exit code 1 | ||
<ERROR> Execution for object " stop_with_integer_code " returned exit code 99 | ||
<ERROR> *cmd_run*:stopping due to failed executions | ||
STOP 1 | ||
``` | ||
The environment variables that might be relevant to reproducing the above behavior | ||
include `FPM_FC`, `FPM_CC`, `FPM_FFLAGS`, `LC_RPATH`, and either `DYLD_LIBRARY_PATH` | ||
on macOS or `LD_LIBRARY_PATH` on Linux. On the macOS system tested, `FPM_FC` | ||
and `FPM_CC` point to `flang-new` and `clang` (version information below), whereas | ||
`LC_RPATH` and `DYLD_LIBRARY_PATH` are both set to the same path as that of `flang-new` | ||
but with the trailing `bin` replaced by `lib`. | ||
|
||
``` | ||
% flang-new --version | ||
flang-new version 20.0.0git ([email protected]:ROCm/llvm-project 27e3c3a2c5716678cef303ba211ccea46a421b00) | ||
Target: arm64-apple-darwin23.6.0 | ||
Thread model: posix | ||
InstalledDir: /Users/rouson/Repositories/llvm-project/install/rocm/bin | ||
Build config: +assertions | ||
``` | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not yet convinced that the proposed change fully resolves all six of the problems outlined in issue #137 that this PR claims to solve. However it might be a step in the right direction? |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
name = "Caffeine-Termination-Tests" | ||
license = "(Please see caffeine/LICENSE.txt.)" | ||
author = "(Please see caffeine/fpm.toml.)" | ||
maintainer = "(Please see caffeine/fpm.toml.)" | ||
|
||
[dev-dependencies] | ||
caffeine = { path = ".." } | ||
|
||
[build] | ||
link = ["gasnet-smp-seq", "gcc"] |
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are adding a project dependence on berkeleylab/assert (which I DO support), then we should also excise the current
caffeine_assert_s
module which was added as a temporary workaround for a lack of a real assertion library.However this change is also orthogonal to the Julienne transition and feels like it belongs in a separate PR.