Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore explicit interface implementations #15

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Ignore explicit interface implementations #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions BepInEx.AssemblyPublicizer/AssemblyPublicizer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,18 @@ private static void Publicize(MethodDefinition methodDefinition, OriginalAttribu
if (methodDefinition.IsCompilerControlled)
return;

// Ignore explicit interface implementations because you can't call them directly anyway and it confuses IDEs
if (methodDefinition is { IsVirtual: true, IsFinal: true, DeclaringType: not null })
{
foreach (var implementation in methodDefinition.DeclaringType.MethodImplementations)
{
if (implementation.Body == methodDefinition)
{
return;
}
}
}

if (!methodDefinition.IsPublic)
{
if (!ignoreCompilerGeneratedCheck && !options.PublicizeCompilerGenerated && methodDefinition.IsCompilerGenerated())
Expand Down
Loading