fix member access for enum and such scanned incorrectly by the ref pa…

…rameter analyzer because of parameter symbol ToString code smell
BepInEx · Jan 24, 2022 · baa8208 · baa8208
1 parent 1490127
commit baa8208
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/BepInEx.Analyzers/BepInEx.Analyzers/HarmonyMethodRefParametersAnalyzer.cs b/BepInEx.Analyzers/BepInEx.Analyzers/HarmonyMethodRefParametersAnalyzer.cs
@@ -61,17 +61,17 @@ private static void CheckExpressionSyntaxes(SyntaxNodeAnalysisContext context, M
                 foreach (var parameter in method.ParameterList.Parameters)
                 {
                     // If parameter is a reference type and is not a literal assignment no warning needed
-                    if (context.SemanticModel.GetDeclaredSymbol(parameter, context.CancellationToken).Type.IsReferenceType)
+                    var parameterSymbol = context.SemanticModel.GetDeclaredSymbol(parameter, context.CancellationToken);
+                    if (parameterSymbol.Type.IsReferenceType)
                     {
                         if (!(expressionSyntaxes[i] is AssignmentExpressionSyntax assignment))
                         {
                             continue;
                         }
                     }
 
-                    // TODO : Looking through the ToString() and "ref" is not the cleanest
-                    var parameterSplit = parameter.ToString().Split(' ');
-                    if (parameterSplit.Any(s => s == varNames[i]) && !parameterSplit.Any(s => s == "ref" || s == "out"))
+                    var paramaterName = parameterSymbol.Name;
+                    if (parameterSymbol.RefKind == RefKind.None && paramaterName == varNames[i])
                     {
                         context.ReportDiagnostic(Diagnostic.Create(Rule, expressionSyntaxes[i].GetLocation(), expressionSyntaxes[i].ToString()));
                     }