Fixed Background Image Visibility Issue on Profile Card (#31) #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openfrontendmentor ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🎉 Thank you @syedfardeenjeelani for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better
beRajeevKumar
requested changes
Oct 15, 2024
There was a problem hiding this comment.
@syedfardeenjeelani, Now background images are not working on mobile devices, so make some changes please then I will merge your branch.
beRajeevKumar
added
bug
sure |
|
@beRajeevKumar kindly review my pr |
|
@beRajeevKumar please review my pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the issue where the background images (
bg-topandbg-bottom) on the profile card disappear or become less visible on smaller screens. The issue is addressed by resizing the background images usingvwunits and adjusting their position to ensure visibility across different viewport sizes.Fixes #31
Type of change
How should this be tested?
bg-topandbg-bottomimages on a mobile screen (max-width: 375px).Mandatory Tasks