This repository has been archived by the owner on Jul 11, 2024. It is now read-only.
Apply the new innerHTML only if the text have actually changed
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding unnecessary HTML parses and DOM rendering
| var text_changed = (original_inner_html.length != reformated_inner_html.length); | ||
| if (text_changed) pre_element.innerHTML = reformated_inner_html; | ||
|
|
||
| pre_element = original_inner_html = reformated_inner_html = text_changed = undefined; |
There was a problem hiding this comment.
This line seems to be useless because they are local variables, no need to reset them.
|
👍 |
|
@fdubost tu l'as testé sur ton Jenkins ? |
|
Oui @KuiKui, j'ai testé |
|
Tu pourrais me remettre en |
KuiKui
added a commit
that referenced
this pull request
Nov 4, 2014
Apply the new `innerHTML` only if the text have actually changed
|
The new version 0.0.4 will be available soon on Chrome Web Store. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will avoid unnecessary HTML parses and DOM rendering.
It is intended as a partial solution to #2.
It does not fully address the problem in that issue since when new content arrives it is possible that the selection is lost.
But it offers a performance improvement when the contents of the console are massive due to reduced HTML parsing and DOM re-rendering.