feat: setup phpstan & rector #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shavounet
force-pushed
the
feat/ci-quality
branch
3 times, most recently
from
498b5be to
53c908c
Compare
Oliboy50
approved these changes
Oct 13, 2023
| $this->sendErrorEvent($request, $reason); | ||
| return $response; | ||
| }, | ||
| function (\Exception $reason) use ($request): never { |
There was a problem hiding this comment.
I didn't know that we could define a return type on a closure... and I'm not sure to understand how it could be a good thing to do so... but I guess we can let rector do whatever it wants 🤷
haflit21
approved these changes
Oct 13, 2023
fferriere
approved these changes
Oct 16, 2023
|
|
||
| /** @var string */ | ||
| protected $clientId; | ||
| protected $events = []; |
There was a problem hiding this comment.
suggestion:
Suggested change
| protected $events = []; | |
| protected array $events = []; |
There was a problem hiding this comment.
As it's a rector change, I won't touch this (might be a BC break if this property is badly used -- maybe this should be in a new PR)
|
|
||
| /** | ||
| * Constructor | ||
| * | ||
| * @param string $clientId | ||
| */ | ||
| public function __construct(EventDispatcherInterface $eventDispatcher, $clientId) | ||
| public function __construct(EventDispatcherInterface $eventDispatcher, protected $clientId) |
There was a problem hiding this comment.
suggestion:
Suggested change
| public function __construct(EventDispatcherInterface $eventDispatcher, protected $clientId) | |
| public function __construct(protected EventDispatcherInterface $eventDispatcher, protected string $clientId) |
There was a problem hiding this comment.
I've applied the 1st change (a524310) but not the 2nd as it might be a BC break (could be done in a new PR I suppose, but I don't want to risk it now)
Meroje
reviewed
Oct 26, 2023
.github/workflows/ci.yml
Outdated
| # TODO add --prefer-lowest once we're ready to handle it | ||
| fail-fast: false | ||
| steps: | ||
| - uses: actions/checkout@master |
There was a problem hiding this comment.
Suggested change
| - uses: actions/checkout@master | |
| - uses: actions/checkout@v4 |
shavounet
force-pushed
the
feat/remove-curl-factory
branch
from
0126cff to
0c247de
Compare
shavounet
force-pushed
the
feat/ci-quality
branch
from
53c908c to
8bef10f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
$quality += 2How?
Setup PHPStan & Rector without caring about fixing everything : that will come later