Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove APC-related constants and references from class.bin.php and class.homepage.php #86

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

N6REJ
Copy link
Contributor

@N6REJ N6REJ commented Sep 20, 2024

User description

remove apc due to security issues reported by synk


PR Type

Bug fix, Enhancement


Description

  • Removed APC-related constants and settings from class.bin.php.php to enhance security and maintainability.
  • Removed APC page references from class.homepage.php to clean up unused code.
  • Deleted the apc.php script entirely due to reported security issues, ensuring the application is more secure.

Changes walkthrough 📝

Relevant files
Enhancement
class.bin.php.php
Remove APC-related constants and settings                               

core/classes/bins/class.bin.php.php

  • Removed APC-related constants.
  • Removed APC settings from getSettings method.
  • Removed APC settings values from getSettingsValues method.
  • +0/-14   
    class.homepage.php
    Remove APC page references from homepage class                     

    core/classes/class.homepage.php

  • Removed APC page constant.
  • Removed APC-related page from pageList.
  • +6/-13   
    Bug fix
    apc.php
    Remove APC PHP script due to security concerns                     

    www/apc.php

    • Deleted the entire APC PHP script.
    +0/-1362

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Key issues to review

    Code Cleanup
    Removal of APC-related constants and settings may require updates to any code that previously relied on these values.

    Potential Broken Links
    Removal of APC page references might lead to broken links if any other parts of the application were linking to the APC page.

    Copy link

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Remove unnecessary empty line at the beginning of the file

    Remove the empty line at the beginning of the file to adhere to PSR-2 coding
    standards.

    core/classes/class.homepage.php [1-3]

     <?php
     /*
    - *
     
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: Removing the unnecessary empty line at the beginning of the file improves adherence to PSR-2 coding standards, enhancing code consistency and readability.

    7
    Update the file header comment format and ensure the copyright year is current

    Consider updating the copyright year to include the current year (2024) in the file
    header comment.

    core/classes/class.homepage.php [2-9]

     /*
      *
    - *  * Copyright (c) 2021-2024 Bearsampp
    - *  * License:  GNU General Public License version 3 or later; see LICENSE.txt
    - *  * Website: https://bearsampp.com
    - *  * Github: https://github.com/Bearsampp
    + * Copyright (c) 2021-2024 Bearsampp
    + * License: GNU General Public License version 3 or later; see LICENSE.txt
    + * Website: https://bearsampp.com
    + * Github: https://github.com/Bearsampp
      *
      */
     
    • Apply this suggestion
    Suggestion importance[1-10]: 5

    Why: The suggestion to update the file header comment format is minor and does not significantly impact the functionality or readability of the code. The copyright year is already current (2024), so the suggestion does not address a necessary change.

    5

    💡 Need additional feedback ? start a PR chat

    @jwaisner jwaisner merged commit d85ae13 into main Sep 25, 2024
    1 check passed
    @jwaisner jwaisner deleted the apc branch September 25, 2024 22:01
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants