Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build UI builder with live svelte #80

Merged
merged 151 commits into from
Apr 1, 2024
Merged

Conversation

cibernox
Copy link
Collaborator

@cibernox cibernox commented Oct 6, 2023

Close #59

  • Add error feedback when saving an empty page or a page with incorrect template. Try creating a new page and hit "Create Draft Page" - nothing is displayed but it should alert the user which error is happening
  • Switching from the code editor to the visual editor should not trigger a save action
  • Add a query param to switch editors
  • Remove the "Beacon CMS" from the preview header? It seems unnecessary now that the page builder is embedded
  • Remove the "D | T | P" from the preview header? I'm not sure what that means
  • Isolate the page stylesheet from the admin stylesheet. Since the page stylesheet is injected into the body it does conflict with the stylesheet on admin causing the admin layout to break so we need to apply a prefix to act as a namespace
  • Only load the visual editor if page.template == heex
  • Only update @page_builder (the AST) when changing tabs (clicking on Visual Editor button) instead of updating it on every keystroke in the code editor
  • Do not crash when page format change from HEEx to Markdown and the template becomes invalid. The user should be able change it back to HEEx

@cibernox cibernox self-assigned this Oct 6, 2023
@cibernox cibernox force-pushed the build-ui-builder-with-live-svelte branch from 0b37e67 to 527e00b Compare November 10, 2023 15:30
leandrocp added a commit to BeaconCMS/beacon that referenced this pull request Nov 21, 2023
To allow generating a small stylesheet for a snippet template,
to be used on the page build.

Related to BeaconCMS/beacon_live_admin#80
leandrocp added a commit to BeaconCMS/beacon that referenced this pull request Nov 21, 2023
* Add RuntimeCSS.compile/2 callback

To allow generating a small stylesheet for a snippet template,
to be used on the page build.

Related to BeaconCMS/beacon_live_admin#80

* run sync test due to mutating the registry
@cibernox cibernox force-pushed the build-ui-builder-with-live-svelte branch from 777a523 to 1db4c3a Compare December 1, 2023 16:03
@leandrocp leandrocp merged commit 28a0d0c into main Apr 1, 2024
3 checks passed
@leandrocp leandrocp deleted the build-ui-builder-with-live-svelte branch April 1, 2024 18:03
@cibernox
Copy link
Collaborator Author

cibernox commented Apr 1, 2024

emotional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Components and Pages: Preview page before publishing and Page Builder improvements
3 participants