Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hm/updates to admin pages and sidenav #67

Merged
merged 14 commits into from
Sep 15, 2023
Merged

Hm/updates to admin pages and sidenav #67

merged 14 commits into from
Sep 15, 2023

Conversation

hanna-del-rae
Copy link
Collaborator

This PR Styles:

  • Layouts
    • Layout edit
    • Meta Tags
    • Resource Links
    • Revisions
  • Pages
    • Page edit
    • Meta Tags
    • Schema
    • Variants
    • Events
    • Revisions
  • Components
    • Edit component
  • Media Library
    • Modals in upload workflow

And Improves the:

  • Icon-only button and link accessibility
  • Focus state of form fields
  • Page titles (Checked with Adam)
  • White-spacing and vertical rhythm on the pages
  • Page scrolling
  • Minimum console sizes for better usability
  • Font sizes and colors (per Figma specs, these may have to be updates later depending on next steps with the designs)
  • Available main-screen space by down-sizing the sidenav

Screenshots of updates

Screenshot 2023-09-01 at 3 04 13 PM
Screenshot 2023-09-01 at 3 04 25 PM
Screenshot 2023-09-01 at 3 04 38 PM
Screenshot 2023-09-01 at 3 04 54 PM
Screenshot 2023-09-01 at 3 05 06 PM
Screenshot 2023-09-01 at 3 05 18 PM
Screenshot 2023-09-01 at 3 05 28 PM
Screenshot 2023-09-01 at 3 05 43 PM
Screenshot 2023-09-01 at 3 05 55 PM
Screenshot 2023-09-01 at 3 06 07 PM
Screenshot 2023-09-01 at 3 06 31 PM
Screenshot 2023-09-01 at 3 06 39 PM

@hanna-del-rae hanna-del-rae marked this pull request as ready for review September 1, 2023 22:16
@hanna-del-rae hanna-del-rae requested review from leandrocp, APB9785 and adam-phillips and removed request for leandrocp September 1, 2023 22:17
leandrocp
leandrocp approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@leandrocp leandrocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 🎉

@leandrocp leandrocp merged commit 8b2a190 into main Sep 15, 2023
3 checks passed
@leandrocp leandrocp deleted the hm/updates-to-admin-pages-and-sidenav branch September 15, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrocp leandrocp leandrocp approved these changes

@APB9785 APB9785 Awaiting requested review from APB9785

@adam-phillips adam-phillips Awaiting requested review from adam-phillips

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanna-del-rae @leandrocp