fix: make Router.reachable/2 less strict #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow root paths / to coexist and start beacon sites even if there's a conflict to allow nested beacon pages as /:page to be served, even in the presence of another live / route
APB9785
reviewed
Dec 10, 2024
The site wouldn't boot in that scenario 35b157b |
|
@APB9785 merging this one now because I need that code :D |
|
This PR fixed my issue where a site would not boot because it was not first in the router, but it may have introduced a new problem. When viewing pages built with Beacon, images only load sometimes. Below is a screen recording of refreshing the media library page. Screen.Recording.2024-12-11.at.10.27.02.AM.mov |
leandrocp
added a commit
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow root paths / to coexist and start beacon sites even if there's a conflict to allow nested beacon pages as /:page to be served, even in the presence of another live / route.
This change will potentially cause more sites to be started but being to restrictive is a breaking change either, so we're partially reverting to v0.2 behavior.