Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beacon generates sitemap.xml per site and a sitemap_index.xml #687

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

APB9785
Copy link
Contributor

@APB9785 APB9785 commented Dec 4, 2024

Resolves #169

Depends on #694

@APB9785 APB9785 self-assigned this Dec 4, 2024
@APB9785 APB9785 changed the title WIP: per-site sitemaps via beacon_site WIP: sitemap.xml + sitemap_index.xml Dec 6, 2024
@APB9785 APB9785 marked this pull request as ready for review December 6, 2024 22:11
@APB9785 APB9785 changed the title WIP: sitemap.xml + sitemap_index.xml sitemap.xml + sitemap_index.xml Dec 6, 2024
@APB9785 APB9785 changed the title sitemap.xml + sitemap_index.xml Beacon generates sitemap.xml per site and a sitemap_index.xml Dec 6, 2024
@APB9785 APB9785 requested a review from leandrocp December 10, 2024 15:32
Copy link
Contributor

@leandrocp leandrocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool. Left some comments but that's looking good.

lib/beacon/loader/routes.ex Show resolved Hide resolved
lib/beacon/router.ex Outdated Show resolved Hide resolved
lib/beacon/router.ex Outdated Show resolved Hide resolved
lib/beacon/router.ex Outdated Show resolved Hide resolved
lib/beacon/web/controllers/sitemap_controller.ex Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate sitemap.xml
2 participants