Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scylla bg quick-fix: remove mention of rainbow #14

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

burkfers
Copy link
Collaborator

@burkfers burkfers commented Mar 16, 2024

The Scylla has no rgb effects beyond the default enabled, but the guide's testing section asks the user to look for a rainbow.

This quick-fix measure duplicates the testing include into the Scylla build guide and changes the wording to refer to the red effect.

Preview: https://finrod09.github.io/bastardkb.github.io/bg_scylla/10install_the_switches.html

@bstiq
Copy link
Member

bstiq commented Mar 17, 2024

Can we not instead enable that rgb animation by default in the Scylla vendor keymap?
It doesn't make sense other keyboards would have it but not the Scylla specifically

@burkfers
Copy link
Collaborator Author

Yes, that would make sense - We probably should make sure the tbkmini and skeletyl follow suit as well (if they don't already have it)

In the meantime, this might reduce confusion; We've already had two help threads about this.

@bstiq
Copy link
Member

bstiq commented Mar 18, 2024

LGTM.
I updated the skeletyl build guide as well.

@bstiq bstiq merged commit 34963c6 into Bastardkb:master Mar 18, 2024
1 check passed
@burkfers burkfers deleted the scylla-test-rgb-anim branch September 20, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants