Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes references to Android v1 embedding. #234

Merged
merged 1 commit into from
May 2, 2024

Conversation

mvanbeusekom
Copy link
Member

The Flutter team is removing references to the Android V1 embedding from their code base (see flutter/flutter#144726). This would mean that code still containing references to the Android V1 embedding will no longer compile.

This PR removes references to Android V1 embedding from the permission_handler_android plugin.

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

@mvanbeusekom mvanbeusekom merged commit 2fd02b2 into main May 2, 2024
1 check passed
@mvanbeusekom mvanbeusekom deleted the feature/remove_v1_embedding branch May 2, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant