Navigate back press fix #433
Conversation
|
@jojonarte What is the state of this branch? Do you need to write any tests or are the existing tests sufficient? |
|
@codeguru42 I want to know your opinion with my tests on this pr. As of the moment I believe I've test as much as I know for backpress. |
|
@jojonarte Please edit the message for your first commit to something more descriptive. It wasn't immediately obvious to me that it has the tests for this issue. I will take a look at them in more detail later this week. |
android/src/main/java/bbct/android/common/activity/BaseballCardList.java
Outdated
Show resolved
Hide resolved
android/src/main/java/bbct/android/common/activity/MainActivity.java
Outdated
Show resolved
Hide resolved
jojonarte
force-pushed
the
navigate_back_press_fix
branch
from
b17c580 to
782c4f4
Compare
jojonarte
force-pushed
the
navigate_back_press_fix
branch
2 times, most recently
from
969c94d to
c3e60dc
Compare
jojonarte
force-pushed
the
navigate_back_press_fix
branch
from
c3e60dc to
0838b9f
Compare
android/src/main/java/bbct/android/common/activity/MainActivity.java
Outdated
Show resolved
Hide resolved
|
When you have time to continue, this should be the next thing. Merge with |
|
@codeguru42 okay thanks |
|
@jojonarte Is there anything else you need to do on this? Or is it ready for a final review? |
|
@codeguru42 there's still some things I have to fix. |
|
@jojonarte Okay. Just ping me when you are finished. |
|
@codeguru42 it's ready for review now. |
|
@codeguru42 it doesn't yet, I'll fix that also don't review yet. Will let you know. |
|
@jojonarte Just to be clear, do you mean you will fix that on this branch? If so, let's close #429. |
|
@codeguru42 yes |
|
@jojonarte Hold that thought. Now that I've looked at #429 more closely, let's keep that separate. I'll review what you have here and merge it so that you can reuse any code you need for fixing #429. Go ahead and work on your other issue for now. |
|
@codeguru42 okay |
|
Is there anything left for this PR? |
|
@jojonarte Thanks for following up on this. This PR is good for the moment. I am not ready to merge it yet until I finish some work I'm doing with #348. It will probably be a while before that one is finished and this one can be merged. In the mean time, feel free to work on #308 or another issue. |
|
This is obsolete after the Kotlin and Jetpack compose rewrite. |
Fix for Issue #334