fix for bazillions of click handlers

Baremetrics · Jan 7, 2019 · 8b56a3a · 8b56a3a
1 parent b688f48
commit 8b56a3a
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 26 deletions.
diff --git a/dev/js/Calendar.js b/dev/js/Calendar.js
@@ -185,23 +185,27 @@
     });
 
     // Once you click into a selection.. this lets you click out
-    this.element.on('click', function() {
-      document.addEventListener('click', function (event) {
-        var contains = $(event.target).parent().closest(self.element);
+    var clickHandler = function(event) {
+      var contains = $(event.target).parent().closest(self.element);
 
-        if (!contains.length) {
-          if (self.presetIsOpen)
-            self.presetToggle();
+      if (!contains.length) {
+        document.removeEventListener('click', clickHandler, false);
 
-          if (self.calIsOpen) {
-            if ($(self.selected).hasClass('dr-date-end'))
-              self.calendarSaveDates();
+        if (self.presetIsOpen)
+          self.presetToggle();
 
-            self.calendarSetDates();
-            self.calendarClose('force');
-          }
+        if (self.calIsOpen) {
+          if ($(self.selected).hasClass('dr-date-end'))
+            self.calendarSaveDates();
+
+          self.calendarSetDates();
+          self.calendarClose('force');
         }
-      });
+      }
+    }
+
+    this.element.on('click', function() {
+      document.addEventListener('click', clickHandler, false);
     });
   }
 

diff --git a/public/js/Calendar.js b/public/js/Calendar.js
@@ -185,23 +185,27 @@
     });
 
     // Once you click into a selection.. this lets you click out
-    this.element.on('click', function() {
-      document.addEventListener('click', function (event) {
-        var contains = $(event.target).parent().closest(self.element);
+    var clickHandler = function(event) {
+      var contains = $(event.target).parent().closest(self.element);
 
-        if (!contains.length) {
-          if (self.presetIsOpen)
-            self.presetToggle();
+      if (!contains.length) {
+        document.removeEventListener('click', clickHandler, false);
 
-          if (self.calIsOpen) {
-            if ($(self.selected).hasClass('dr-date-end'))
-              self.calendarSaveDates();
+        if (self.presetIsOpen)
+          self.presetToggle();
 
-            self.calendarSetDates();
-            self.calendarClose('force');
-          }
+        if (self.calIsOpen) {
+          if ($(self.selected).hasClass('dr-date-end'))
+            self.calendarSaveDates();
+
+          self.calendarSetDates();
+          self.calendarClose('force');
         }
-      });
+      }
+    }
+
+    this.element.on('click', function() {
+      document.addEventListener('click', clickHandler, false);
     });
   }