Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transit uris #76

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix transit uris #76

wants to merge 2 commits into from

Conversation

peterneyens
Copy link
Contributor

Don't uri encode the key in the transit endpoints.

This is consistent with how dynamic uris are created within Vaults (example).

@peterneyens
Fix transit uris
55b4672 
Don't uri encode key paths
@ChristopherDavenport
Copy link
Collaborator

Should probably leave a warning as this will now break if {key.name} starts with /, I mean no worse than we are presently broken. But good that we make that clear in documentation somewhere.

ChristopherDavenport
ChristopherDavenport approved these changes Jan 14, 2020
View reviewed changes
Copy link
Collaborator

@ChristopherDavenport ChristopherDavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For making the comment later and fixing uat sooner rather than later.

Base automatically changed from master to main March 22, 2021 16:13
@rossabaker
Copy link
Collaborator

Looks like this got bogged down as a change in behavior. Can we get it into the 8.x and 9.x releases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherDavenport ChristopherDavenport ChristopherDavenport approved these changes

@ccarlile ccarlile ccarlile approved these changes

@diesalbla diesalbla diesalbla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peterneyens @ChristopherDavenport @rossabaker @diesalbla @ccarlile