CVE-2023-39410: bump avro4s #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossabaker
commented
Oct 4, 2023
| @@ -203,6 +204,7 @@ lazy val commonSettings = Seq( | |||
| "co.fs2" %% "fs2-core" % V.fs2, | |||
| "org.apache.kafka" % "kafka-clients" % V.kafka, | |||
| "io.confluent" % "kafka-avro-serializer" % V.confluent, | |||
| "org.apache.avro" % "avro" % V.avro % Compile, // CVE-2023-39410, didn't work as Runtime | |||
There was a problem hiding this comment.
I don't know why Runtime doesn't work here. It didn't work for Guava, either.
There was a problem hiding this comment.
I do not know why % Compile works either, so we are equally ignorant footing 😛
There was a problem hiding this comment.
Oh, % Compile is the default. It's in the same scope as kafka-avro-serializer, which is what brings it in. But runtime dependencies should propagate into the runtime of downstream, so I'm confused. We do similar in lots of other places and it works.
OddKristensen
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.