DX-2798: Fix ImportTnCheckerPayload XML Serialization (#69)

DX-2798: Fix ImportTnCheckerPayload XML Serialization
Bandwidth · Sep 6, 2022 · 06e4050 · 06e4050
2 parents 736e320 + 0b3dbf5
commit 06e4050
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 9 deletions.
diff --git a/.gitignore b/.gitignore
@@ -195,5 +195,6 @@ FakesAssemblies/
 .tmproj
 nbproject
 Thumbs.db
+.vscode
 
 .vs
diff --git a/Bandwidth.Iris.Tests/Models/ImportTnCheckerTests.cs b/Bandwidth.Iris.Tests/Models/ImportTnCheckerTests.cs
@@ -1,12 +1,14 @@
 using System;
 using System.Net.Http;
 using System.Text;
+using System.Xml.Serialization;
+using System.IO;
 using Bandwidth.Iris.Model;
 using Xunit;
 
 namespace Bandwidth.Iris.Tests.Models
 {
-    
+
     public class ImportTnCheckerTests
     {
         [Fact]
@@ -15,13 +17,12 @@ public void TestCreate()
 
             var order = new ImportTnCheckerPayload
             {
-                TelephoneNumbers = new TelephoneNumber[]
-               {
-                   new TelephoneNumber
-                   {
-                       FullNumber = "3032281000"
-                   }
-               }
+                SiteId = "486",
+                SipPeerId = "500025",
+                TelephoneNumbers = new string[]
+                {
+                    "3032281000"
+                }
             };
 
             using (var server = new HttpServer(new RequestHandler
@@ -44,5 +45,30 @@ public void TestCreate()
 
             }
         }
+
+        [Fact]
+        public void TestSerialize()
+        {
+            var order = new ImportTnCheckerPayload
+            {
+                SiteId = "486",
+                SipPeerId = "500025",
+                TelephoneNumbers = new string[]
+                {
+                    "3032281000"
+                }
+            };
+
+            XmlSerializer xs = new XmlSerializer(typeof(ImportTnCheckerPayload));
+
+            string xmlStringResult = null;
+            using (StringWriter writer = new StringWriter())
+            {
+                xs.Serialize(writer, order);
+                xmlStringResult = writer.ToString();
+
+                Assert.Equal(TestXmlStrings.ImportTnCheckerSampleSerialization, xmlStringResult);
+            }
+        }
     }
 }
diff --git a/Bandwidth.Iris.Tests/TestXmlStrings.cs b/Bandwidth.Iris.Tests/TestXmlStrings.cs
@@ -774,6 +774,8 @@ public static class TestXmlStrings
 
         public static string ImportTnCheckerResponse = $"<ImportTnCheckerResponse>{ImportTnCheckerPayload}</ImportTnCheckerResponse>";
 
+        public static string ImportTnCheckerSampleSerialization = "<?xml version=\"1.0\" encoding=\"utf-16\"?>\n<ImportTnCheckerPayload xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xmlns:xsd=\"http://www.w3.org/2001/XMLSchema\">\n  <SiteId>486</SiteId>\n  <SipPeerId>500025</SipPeerId>\n  <TelephoneNumbers>\n    <TelephoneNumber>3032281000</TelephoneNumber>\n  </TelephoneNumbers>\n</ImportTnCheckerPayload>";
+
         public static string RemoveImportedOrder = @"<RemoveImportedTnOrder>
                                                         <CustomerOrderId>SJM000001</CustomerOrderId>
                                                         <OrderCreateDate>2018-01-20T02:59:54.000Z</OrderCreateDate>

diff --git a/Bandwidth.Iris/Model/ImportTnChecker.cs b/Bandwidth.Iris/Model/ImportTnChecker.cs
@@ -22,7 +22,14 @@ public static Task<ImportTnCheckerResponse> Create(ImportTnCheckerPayload payloa
 
     public class ImportTnCheckerPayload
     {
-        public TelephoneNumber[] TelephoneNumbers { get; set; }
+        public string SiteId { get; set; }
+
+        public string SipPeerId { get; set; }
+
+        [XmlArray("TelephoneNumbers")]
+        [XmlArrayItem("TelephoneNumber")]
+        public string[] TelephoneNumbers { get; set; }
+
         [XmlArray("ImportTnErrors")]
         [XmlArrayItem("ImportTnError")]
         public ImportTnError[] ImportTnErrors { get; set; }