Merge pull request #95 from redcarrera/20230817

Document meaning of return values from bg_trimesh_solid
BRL-CAD · Aug 17, 2023 · e118c7d · e118c7d
2 parents a87b356 + c59dcc4
commit e118c7d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/include/bg/trimesh.h b/include/bg/trimesh.h
@@ -84,8 +84,9 @@ BG_EXPORT extern int bg_trimesh_manifold_closed(int vcnt, int fcnt, fastf_t *v,
 BG_EXPORT extern int bg_trimesh_oriented(int vcnt, int fcnt, fastf_t *v, int *f);
 
 /**
- * Check if a mesh is topologically solid. True if the mesh is closed,
- * manifold, and oriented.
+ * Check if a mesh is topologically solid. Returns TRUE if the mesh is
+ * NOT SOLID and FALSE if the mesh is SOLID. A FALSE outcome indicates
+ * the mesh satisfies all three criteria:  Closed, Manifold, Oriented
  */
 BG_EXPORT extern int bg_trimesh_solid(int vcnt, int fcnt, fastf_t *v, int *f, int **bedges);
 

diff --git a/src/libbg/trimesh.cpp b/src/libbg/trimesh.cpp
@@ -381,7 +381,8 @@ bg_trimesh_solid(int vcnt, int fcnt, fastf_t *v, int *f, int **bedges)
 	bedge_cnt = bg_trimesh_solid2(vcnt, fcnt, v, f, NULL);
     }
 
-    return bedge_cnt;
+    /* returns true when not solid */
+    return (bedge_cnt > 0) ? 1 : 0;
 }
 
 int