Improvements and fixes for primitive types #2 #54
Conversation
dr-orlovsky
added
bug
primitives/src/util.rs
Outdated
|
|
||
| impl Chain { | ||
| #[inline] | ||
| pub fn is_testnet(self) -> bool { |
There was a problem hiding this comment.
IMO inverting logic and calling the method is_mainnet would be clearer
There was a problem hiding this comment.
I do not agree. Right now there is just one mainnet: Chain::Bitcoin and one can just test it against it. Testnets are multiple and their number may be growing.
In the future more non-testnets may be added (for instance prime). But they are also not "mainnets". Thus since we need to test against testnet/non-testnet - we need method named is_testnet and not is_mainnet.
There was a problem hiding this comment.
IMO is_testnet is confusing since there is a specific network called "testnet". Maybe we could call it is_test_network?
There was a problem hiding this comment.
Agree that it is confusing. Probably better is_test or has_no_value?
BTW the full name for the testnet is testnet3. Testnet is not running anymore.
There was a problem hiding this comment.
I still prefer is_test_network but is_test also seems ok.
I know that there's testnet3 but since testnet1 and testnet2 have been dismissed everyone just calls it testnet.
There was a problem hiding this comment.
I did is_test_chain (since the name of the type is Chain and not Network). Also seems not to conflict with "testnet"
dr-orlovsky
force-pushed
the
primitives
branch
from
91eab32 to
272faaf
Compare
dr-orlovsky
force-pushed
the
primitives
branch
from
95b35ee to
64477b5
Compare
dr-orlovsky
changed the title
|
Ok, I am planning to merge it as it is - since downstream in Next, I will probably do another ongoing PR here, but this one I think should be merged since contains important fixes (like invalid Txid serde serialization for JSON etc). @zoedberg I need your ACK |
As a part of my work on making sure that all RGB wallet-related tasks (including Tapret) are working as required I stumble upon issues and bugs, which are being progressively fixed in this branch