Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rtl direction from carousel-slide to carousel-track #140

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Move rtl direction from carousel-slide to carousel-track #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/ssr-carousel-track.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,14 +198,14 @@ export default
&.dragging
pointer-events none

// Apply direction property which was reset in .ssr-carousel
&.ssr-carousel-rtl
direction rtl

Comment on lines +201 to +204
Copy link
Member

@weotch weotch Feb 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have thought this would mess up the layout of the slides on the track. Also, the carousel looks broke on the deploy preview: https://deploy-preview-140--vue-ssr-carousel.netlify.app/accessibility/

vue-ssr-carousel demo 2024-02-05 at 4 23 23 PM jpg

You sure about this change?

// Force the slides to not shrink below their basis
.ssr-carousel-slide
flex-shrink 0

// Apply direction property which was reset in .ssr-carousel
.ssr-carousel-rtl &
direction rtl

// When the carousel is disabled (not enough slides to fill width), hide any
// clones that have created for other breakpoints (those with aria-hidden=true).
.ssr-carousel-mask.disabled .ssr-carousel-slide[aria-hidden='true']
Expand Down
Loading