Refactor the Code For Netbeans UI designer #40
+57
−79
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -84,7 +84,7 @@ private void initComponents() { | |
| restultsJTable = new javax.swing.JTable(); | ||
|
|
||
| setDefaultCloseOperation(javax.swing.WindowConstants.DISPOSE_ON_CLOSE); | ||
|
There was a problem hiding this comment. Did you mean to remove the title? There was a problem hiding this comment. This String is already Set in newSuggestionForm.form And this is now duplicated. |
||
|
|
||
| cancleJButton.setText("Cancel"); | ||
| cancleJButton.addActionListener(new java.awt.event.ActionListener() { | ||
| public void actionPerformed(java.awt.event.ActionEvent evt) { | ||
|
|
@@ -96,16 +96,11 @@ public void actionPerformed(java.awt.event.ActionEvent evt) { | |
| jLabel1.setText("Custom lookup"); | ||
|
|
||
| dependentJLabel.setText("Dependent:"); | ||
|
There was a problem hiding this comment. Did you mean to remove this listener? There was a problem hiding this comment. Okay... but why did you decide to remove it? |
||
|
|
||
| selectionJLabel.setText("Selection:"); | ||
|
|
||
| selectionJTextField.setMinimumSize(new java.awt.Dimension(200, 22)); | ||
|
|
||
| fetchjButton.setText("Search..."); | ||
| fetchjButton.addActionListener(new java.awt.event.ActionListener() { | ||
| public void actionPerformed(java.awt.event.ActionEvent evt) { | ||
|
|
@@ -115,16 +110,17 @@ public void actionPerformed(java.awt.event.ActionEvent evt) { | |
|
|
||
| restultsJTable.setModel(new javax.swing.table.DefaultTableModel( | ||
| new Object [][] { | ||
|
|
||
| }, | ||
| new String [] { | ||
| "Value", "Description" | ||
| } | ||
| ) { | ||
| Class[] types = new Class [] { | ||
| java.lang.String.class, java.lang.String.class | ||
| }; | ||
| boolean[] canEdit = new boolean [] { | ||
| false, false | ||
| }; | ||
|
|
||
| public Class getColumnClass(int columnIndex) { | ||
|
|
@@ -144,11 +140,6 @@ public void mousePressed(java.awt.event.MouseEvent evt) { | |
| jScrollPane2.setViewportView(restultsJTable); | ||
| restultsJTable.getColumnModel().getSelectionModel().setSelectionMode(javax.swing.ListSelectionModel.SINGLE_SELECTION); | ||
|
|
||
| javax.swing.GroupLayout layout = new javax.swing.GroupLayout(getContentPane()); | ||
| getContentPane().setLayout(layout); | ||
| layout.setHorizontalGroup( | ||
|
|
@@ -159,22 +150,20 @@ public void mousePressed(java.awt.event.MouseEvent evt) { | |
| .addGroup(javax.swing.GroupLayout.Alignment.TRAILING, layout.createSequentialGroup() | ||
| .addGap(0, 0, Short.MAX_VALUE) | ||
| .addComponent(cancleJButton)) | ||
| .addComponent(jScrollPane2, javax.swing.GroupLayout.DEFAULT_SIZE, 706, Short.MAX_VALUE) | ||
| .addGroup(layout.createParallelGroup(javax.swing.GroupLayout.Alignment.LEADING, false) | ||
| .addComponent(jLabel1) | ||
| .addGroup(layout.createSequentialGroup() | ||
| .addGap(8, 8, 8) | ||
| .addComponent(selectionJLabel) | ||
| .addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.RELATED) | ||
| .addComponent(selectionJTextField, javax.swing.GroupLayout.DEFAULT_SIZE, javax.swing.GroupLayout.DEFAULT_SIZE, Short.MAX_VALUE)) | ||
| .addGroup(layout.createSequentialGroup() | ||
| .addGap(6, 6, 6) | ||
| .addComponent(dependentJLabel) | ||
| .addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.RELATED) | ||
| .addComponent(dependentJTextField, javax.swing.GroupLayout.DEFAULT_SIZE, 306, Short.MAX_VALUE)) | ||
| .addComponent(fetchjButton, javax.swing.GroupLayout.Alignment.TRAILING, javax.swing.GroupLayout.PREFERRED_SIZE, 92, javax.swing.GroupLayout.PREFERRED_SIZE))) | ||
| .addContainerGap()) | ||
| ); | ||
| layout.setVerticalGroup( | ||
|
|
@@ -189,7 +178,7 @@ public void mousePressed(java.awt.event.MouseEvent evt) { | |
| .addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.RELATED) | ||
| .addGroup(layout.createParallelGroup(javax.swing.GroupLayout.Alignment.BASELINE) | ||
| .addComponent(selectionJLabel) | ||
| .addComponent(selectionJTextField, javax.swing.GroupLayout.DEFAULT_SIZE, javax.swing.GroupLayout.DEFAULT_SIZE, Short.MAX_VALUE)) | ||
| .addGap(8, 8, 8) | ||
| .addComponent(fetchjButton) | ||
| .addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.UNRELATED) | ||
|
|
@@ -199,6 +188,9 @@ public void mousePressed(java.awt.event.MouseEvent evt) { | |
| .addContainerGap()) | ||
| ); | ||
|
|
||
|
|
||
| // this will break the UI design in netbeans IDE but no alternative | ||
| // was found to get the text change event | ||
| selectionJTextField.getDocument().addDocumentListener(new DocumentListener() { | ||
| public void insertUpdate(DocumentEvent e) { | ||
| textChanged(); | ||
|
|
@@ -238,10 +230,6 @@ private void cancleJButtonActionPerformed(java.awt.event.ActionEvent evt) {//GEN | |
| dispose(); | ||
| }//GEN-LAST:event_cancleJButtonActionPerformed | ||
|
|
||
| private void fetchjButtonActionPerformed(java.awt.event.ActionEvent evt) {//GEN-FIRST:event_fetchjButtonActionPerformed | ||
| // TODO add your handling code here: | ||
|
|
||
|
|
@@ -296,6 +284,7 @@ private void restultsJTableMousePressed(java.awt.event.MouseEvent evt) {//GEN-FI | |
|
|
||
| }//GEN-LAST:event_restultsJTableMousePressed | ||
|
|
||
|
|
||
| // /** | ||
| // * @param args the command line arguments | ||
| // */ | ||
|
|
@@ -340,13 +329,13 @@ private void restultsJTableMousePressed(java.awt.event.MouseEvent evt) {//GEN-FI | |
|
|
||
| // Variables declaration - do not modify//GEN-BEGIN:variables | ||
| private javax.swing.JButton cancleJButton; | ||
| private javax.swing.JLabel dependentJLabel; | ||
| private javax.swing.JTextField dependentJTextField; | ||
| private javax.swing.JButton fetchjButton; | ||
| private javax.swing.JLabel jLabel1; | ||
| private javax.swing.JScrollPane jScrollPane2; | ||
| private javax.swing.JTable restultsJTable; | ||
| private javax.swing.JLabel selectionJLabel; | ||
| private javax.swing.JTextField selectionJTextField; | ||
| // End of variables declaration//GEN-END:variables | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to rename the text of this label?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is that? It doesn't seem related to the title of the PR?