[fix] always show the custom lookup

[marmoure]

Fixes #14
The Custom Look Up will always be shown on top even when we have matches results

[ttasovac]

@marmoure thanks a lot for this super quick implementation. could you please move the custom look up to appear below the matched results, so that it's easier for the user to select the matched result if they are correct.

[marmoure]

@ttasovac
The order should be better now
i had to prefix every matched results with a space and pre fix the Custom Lookup... with double quotas
the order is being done by Oxygen XML following ASCII Table

[ttasovac]

thanks, @marmoure. i wonder if that's the only way to go about it. perhaps @adamretter can take a look as well?

[adamretter]

i wonder if that's the only way to go about it. perhaps @adamretter can take a look as well?

@ttasovac The difficulty we have is that we can only present a list of strings back to OxygenXML, and it is up to Oxygen how they order the list. They appear to sort the results lexicographically.

I am not sure I am completely clear on what you are asking for. Is the goal here to place Custom Entry... last in the list?

i had to prefix every matched results with a space and pre fix the Custom Lookup... with double quotas
the order is being done by Oxygen XML following ASCII Table

If the Goal is to place Custom Entry... last in the list, if we assume that the sorting is likely lexicographically based on the UTF-8 character set, all we need do is prefix Custom Entry... with some character (possibly non-visible) that has a higher character code than any that would likely appear in the normal results. Perhaps something like 👉 Custom Entry... would suffice? See: https://www.fileformat.info/info/emoji/point_right/index.htm

[ttasovac]

Yes, indeed, the goal is for the lookup link to be last in the list.

👉 Custom Entry... looks good — people will think we added it on purpose and not as a hack! 😄 So let's do that. Thanks, Adam!

[marmoure]

i still had to prefix the emoji with a space to bump it to the top
how does this look? @ttasovac

Also do you think we should keep the space in front of the emoji?
Here's the results without that space

[ttasovac]

@marmoure the goal is to have the link appear last, so I'm not sure why your screenshots have it appear between #frd and #bibl elements. we need a space between the emoji and "Custom lookup" string, but not before the emoji. Since we're looking at a dropdown list, an indentation in only one line makes it look a bit messy.

please try again — with an understanding that the custom lookup link should appear after all the results.

[marmoure]

Sorry @ttasovac for the misunderstanding, My assumption was that 👉 Custom Lookup... should be after the results we got from TEI-Completer and before the ones Oxygen suggested
In this Case #frd came from TEI-Completer and #bibl were suggested by Oxygen
I have now pushed the 👉 Custom Lookup... to the bottom of the list, and i m still pushing the results from TEI-Completer to the top by prefixing with a Space