Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace usages of pkg_resources with importlib.metadata #941

Merged
merged 8 commits into from
Aug 5, 2024

Conversation

zacharyburnett
Copy link
Contributor

@zacharyburnett zacharyburnett commented Jul 18, 2024

Changes

attempting to fix issues in readthedocs build:

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/weldx/checkouts/940/doc/src/conf.py", line 65, in <module>
    import weldx
  File "/home/docs/checkouts/readthedocs.org/user_builds/weldx/conda/940/lib/python3.10/site-packages/weldx/__init__.py", line 144, in <module>
    import weldx.config
  File "/home/docs/checkouts/readthedocs.org/user_builds/weldx/conda/940/lib/python3.10/site-packages/weldx/config.py", line 8, in <module>
    import pkg_resources
  File "/home/docs/checkouts/readthedocs.org/user_builds/weldx/conda/940/lib/python3.10/site-packages/pkg_resources/__init__.py", line 105, in <module>
    from _typeshed import BytesPath, StrPath, StrOrBytesPath
ModuleNotFoundError: No module named '_typeshed'

https://readthedocs.org/projects/weldx/builds/25043814/

Related Issues

Checks

  • updated CHANGELOG.md
  • updated tests/
  • updated doc/
  • update example/tutorial notebooks
  • update manifest file

Copy link

github-actions bot commented Aug 5, 2024

Test Results

2 188 tests  ±0   2 187 ✅ ±0   1m 56s ⏱️ -1s
    1 suites ±0       1 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit c7585e6. ± Comparison against base commit b5e2131.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.42%. Comparing base (5ad2929) to head (c7585e6).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
weldx/config.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #941      +/-   ##
==========================================
- Coverage   96.48%   96.42%   -0.06%     
==========================================
  Files          95       95              
  Lines        6293     6301       +8     
==========================================
+ Hits         6072     6076       +4     
- Misses        221      225       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CagtayFabry CagtayFabry self-assigned this Aug 5, 2024
@CagtayFabry CagtayFabry added deprecation function or dependency deprecations dependencies changes in package dependencies units unit handling and pint labels Aug 5, 2024
@CagtayFabry CagtayFabry linked an issue Aug 5, 2024 that may be closed by this pull request
@CagtayFabry CagtayFabry marked this pull request as ready for review August 5, 2024 13:14
@CagtayFabry
Copy link
Member

Thank you for starting this @zacharyburnett ! This was bothering me for a long time.
I included some changes to simplify version specific parts of the code as well, I hope you don't mind me using this PR.

@CagtayFabry CagtayFabry enabled auto-merge (squash) August 5, 2024 13:51
@CagtayFabry CagtayFabry self-requested a review August 5, 2024 13:51
@CagtayFabry CagtayFabry disabled auto-merge August 5, 2024 14:16
@CagtayFabry CagtayFabry merged commit 35f92d7 into BAMWelDX:master Aug 5, 2024
20 of 21 checks passed
@zacharyburnett zacharyburnett deleted the fix/docs branch August 6, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies changes in package dependencies deprecation function or dependency deprecations units unit handling and pint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg_resources is deprecated
2 participants