Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Python 3.12 to test #896

Merged
merged 21 commits into from
Nov 5, 2024
Merged

add Python 3.12 to test #896

merged 21 commits into from
Nov 5, 2024

Conversation

CagtayFabry
Copy link
Member

@CagtayFabry CagtayFabry commented Oct 3, 2023

Changes

  • add Python 3.12 and 3.13 to pytest runs
  • switch Python 3.9 -> 3.10 in some default runs

Related Issues

Checks

  • updated CHANGELOG.md
  • updated tests/
  • updated doc/
  • update example/tutorial notebooks
  • update manifest file

@CagtayFabry CagtayFabry added the dependencies changes in package dependencies label Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing base (5ad2929) to head (52f1a71).
Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
- Coverage   96.48%   96.38%   -0.11%     
==========================================
  Files          95       95              
  Lines        6293     6310      +17     
==========================================
+ Hits         6072     6082      +10     
- Misses        221      228       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Test Results

2 188 tests  +2 188   2 187 ✅ +2 187   2m 3s ⏱️ + 2m 3s
    1 suites +    1       1 💤 +    1 
    1 files   +    1       0 ❌ ±    0 

Results for commit 52f1a71. ± Comparison against base commit d7be2b0.

♻️ This comment has been updated with latest results.

@marscher
Copy link
Contributor

Conda environments cannot be properly created due to the missing mapping of different package names in pip and conda CagtayFabry/pydeps2env#6

This is not specific to Python 3.12 but all Python versions.

@marscher
Copy link
Contributor

We first need to unblock weldx-widgets for Python 3.12.
Is it blocked for the same reasons as weldx @CagtayFabry?

@marscher
Copy link
Contributor

The windows test is not passing because of some broken M$ caching. It cannot find the tag in my pydeps2env fork (Linux systems pick it up). So I guess CagtayFabry/pydeps2env#57 is the last requirement for this PR @CagtayFabry

@marscher
Copy link
Contributor

marscher commented Oct 28, 2024

Python 3.13 has not been released yet. We should allow failures for this version in our matrix. The current failure is due to Pandas is not yet ready for 3.13.

"Allow failures" is not (yet) implemented for github runners: actions/runner#2347

@marscher marscher changed the title add Python 3.12 tests add Python 3.[12, 13] tests Oct 28, 2024
@CagtayFabry
Copy link
Member Author

Python 3.13 has not been released yet. We should allow failures for this version in our matrix. The current failure is due to Pandas is not yet ready for 3.13.

"Allow failures" is not (yet) implemented for github runners: actions/runner#2347

Python 3.13 was released a few weeks ago :)
https://docs.python.org/3/whatsnew/3.13.html
https://anaconda.org/conda-forge/python

Numpy 1.26 doesn't support Python 3.13 however, so we need numpy>=2.1 which is blocked in weldx-widgets requirements for now

@marscher
Copy link
Contributor

Thanks! I will fix this is in wx-widgets then!

@marscher
Copy link
Contributor

fixed the np 2.0 compat, but pint is not py 3.13 ready.

@CagtayFabry
Copy link
Member Author

since there hasn't been an update regarding pint compatibility with 3.13 in that repository I propose to move this forward with 3.12 and add testing with 3.13 as it becomes available 😃

@CagtayFabry CagtayFabry changed the title add Python 3.[12, 13] tests add Python 3.12 to test Nov 5, 2024
@CagtayFabry CagtayFabry requested a review from marscher November 5, 2024 12:09
@CagtayFabry CagtayFabry self-assigned this Nov 5, 2024
@CagtayFabry CagtayFabry removed the request for review from marscher November 5, 2024 12:09
@CagtayFabry CagtayFabry disabled auto-merge November 5, 2024 12:10
@CagtayFabry CagtayFabry merged commit 8a34f2d into BAMWelDX:master Nov 5, 2024
22 checks passed
@CagtayFabry CagtayFabry deleted the py312 branch November 5, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies changes in package dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants