-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates for .NET 9 #3142
updates for .NET 9 #3142
Conversation
.github/workflows/dotnetcore.yml
Outdated
|
||
strategy: | ||
matrix: | ||
dotnet-version:[ '6.0.x', '7.0.x', '8.0.x', '9.0.x' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems to help against any issues w/the frameworks not running properly, there seemed to be an issue w/the wrong framework running on the OIDC tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried installing all frameworks yesterday, it didn't help. But if this works, then it works...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it worked when I did a test PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not what it showed. and then I changed the base branch so I don't have proof.
@@ -16,7 +16,7 @@ foreach ($line in $($publishOutput -split "`r`n")) | |||
} | |||
|
|||
Write-Host "Actual warning count is: ", $actualWarningCount | |||
$expectedWarningCount = 63 | |||
$expectedWarningCount = 61 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the count is lower, that is okay. we don't want it going up. I assume some dependencies were updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you saying that 2 APIs were made AOT compatible so they don't throw warnings? Should we find and compare which ones they are?
No description provided.