Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for .NET 9 #3142

Closed
wants to merge 19 commits into from
Closed

updates for .NET 9 #3142

wants to merge 19 commits into from

Conversation

jennyf19
Copy link
Collaborator

No description provided.

@jennyf19 jennyf19 requested a review from a team as a code owner November 13, 2024 17:44
@jennyf19 jennyf19 changed the base branch from master to pmaytak/net9 November 13, 2024 17:59
@jennyf19 jennyf19 changed the title [TEST}Jennyf/net9 test updates for .NET 9 Nov 13, 2024

strategy:
matrix:
dotnet-version:[ '6.0.x', '7.0.x', '8.0.x', '9.0.x' ]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to help against any issues w/the frameworks not running properly, there seemed to be an issue w/the wrong framework running on the OIDC tests

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried installing all frameworks yesterday, it didn't help. But if this works, then it works...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it worked when I did a test PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not what it showed. and then I changed the base branch so I don't have proof.

@@ -16,7 +16,7 @@ foreach ($line in $($publishOutput -split "`r`n"))
}

Write-Host "Actual warning count is: ", $actualWarningCount
$expectedWarningCount = 63
$expectedWarningCount = 61
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the count is lower, that is okay. we don't want it going up. I assume some dependencies were updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you saying that 2 APIs were made AOT compatible so they don't throw warnings? Should we find and compare which ones they are?

@pmaytak pmaytak self-requested a review November 13, 2024 18:13
@jennyf19 jennyf19 closed this Nov 13, 2024
@jennyf19 jennyf19 reopened this Nov 13, 2024
@jennyf19 jennyf19 changed the base branch from pmaytak/net9 to master November 13, 2024 18:23
@jennyf19 jennyf19 closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants