Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing draft version to .38 and removing manual appname #874

Merged
merged 1 commit into from
Aug 23, 2024
Merged

changing draft version to .38 and removing manual appname #874

merged 1 commit into from
Aug 23, 2024

Conversation

ReinierCC
Copy link
Collaborator

@ReinierCC ReinierCC commented Aug 23, 2024

Original PR: #830

Had to update for latest draft version and retest.

@ReinierCC ReinierCC mentioned this pull request Aug 23, 2024
@ReinierCC ReinierCC added bug Something isn't working enhancement 🚀 New feature or request or improvements on existing code. labels Aug 23, 2024
@ReinierCC
Copy link
Collaborator Author

Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☕️🙏❤️ nice!! Looks good!! Let’s get this tested. Thank you for this.

Copy link
Collaborator

@hsubramanianaks hsubramanianaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm , please do run a test to make sure it is working. Thanks @ReinierCC

@ReinierCC
Copy link
Collaborator Author

Tested on my end. Closing now :)

@ReinierCC ReinierCC merged commit e7b7999 into Azure:main Aug 23, 2024
8 checks passed
Tatsinnit pushed a commit to Tatsinnit/vscode-aks-tools that referenced this pull request Aug 23, 2024
tejhan pushed a commit to tejhan/vscode-aks-tools that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement 🚀 New feature or request or improvements on existing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants