-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump eslint from 8.57.0 to 9.9.0 in /webview-ui #862
Conversation
10d995f
to
ec29354
Compare
Bumps [eslint](https://github.com/eslint/eslint) from 8.57.0 to 9.9.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.57.0...v9.9.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
ec29354
to
ddc0a21
Compare
This seems like major breaking change: https://eslint.org/docs/latest/use/migrate-to-9.0.0 More context here: typescript-eslint/typescript-eslint#8766 Thanks. |
The issue seems to be that Dependabot attempted to upgrade eslint from 8.57 to 9.9 in the webview folder, but "eslint-plugin-react-hooks" (v 4.6.2) doesn't support eslint v9 as of yet (facebook/react#28773). Thus, there is a peer dependency issue between the two, which caused unresolved errors during the build. We will keep v8 of eslint until eslint-plugin-react-hooks supports v9 in a future stable release. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Superseded by #885. |
Bumps eslint from 8.57.0 to 9.9.0.
Release notes
Sourced from eslint's releases.
... (truncated)
Changelog
Sourced from eslint's changelog.
... (truncated)
Commits
0dd3863
9.9.02e5ba77
Build: changelog update for 9.9.0461b2c3
chore: upgrade to@eslint/[email protected]
(#18765)59dba1b
chore: package.json update for@eslint/js
releasefea8563
chore: update dependency@eslint/core
to ^0.3.0 (#18724)41d0206
feat: Add support for TS config files (#18134)aac191e
chore: update dependency@eslint/json
to ^0.3.0 (#18760)9fe068c
docs: how to author plugins with configs that extend other configs (#18753)b97fa05
chore: update wdio dependencies for more stable tests (#18759)3a4eaf9
feat: add suggestion torequire-await
to removeasync
keyword (#18716)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)