Escaping special regex chars #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tatsinnit
added
bug
Tatsinnit
reviewed
Aug 8, 2024
Tatsinnit
reviewed
Aug 8, 2024
added 3 commits
August 19, 2024 20:11
hsubramanianaks
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
lgtm, just make sure to run a manual test for tcp dump to make sure it works. Thanks for finding this and fixing it @ReinierCC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To properly sanitize input strings we have to escape any special characters.
Wanted to get some feedback on this implementation, where I manually specified the special characters and are escaping.
Some other potential routes would be to use a library with this feature but, this would create a new dependency.
Currently have a simple test function in the same file. Can move this to a more appropriate location after feedback.