Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated github auth scope to repo #832

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Updated github auth scope to repo #832

merged 2 commits into from
Aug 13, 2024

Conversation

ReinierCC
Copy link
Collaborator

Previous github authentication token only provided access to publicly available repos., which prevented the extension from populating any private repos the user might have had.

@hsubramanianaks hsubramanianaks self-requested a review August 2, 2024 19:40
@hsubramanianaks hsubramanianaks linked an issue Aug 2, 2024 that may be closed by this pull request
@hsubramanianaks hsubramanianaks added bug Something isn't working enhancement 🚀 New feature or request or improvements on existing code. labels Aug 2, 2024
@ReinierCC
Copy link
Collaborator Author

image

@ReinierCC
Copy link
Collaborator Author

Copy link
Collaborator

@hsubramanianaks hsubramanianaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, Minor suggestion about the documentation. Thanks @ReinierCC

src/commands/draft/draftCommands.ts Show resolved Hide resolved
Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and thank you so much for this. Let's get approval from @hsubramanianaks around this as well as he added context from initial PR. thanks both!!

@hsubramanianaks hsubramanianaks merged commit 2cc4716 into Azure:main Aug 13, 2024
8 checks passed
tejhan pushed a commit to tejhan/vscode-aks-tools that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement 🚀 New feature or request or improvements on existing code.
Projects
Development

Successfully merging this pull request may close these issues.

Draft Github Workflow does not populate repositories
3 participants