Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TCP Dump #281

Merged
merged 16 commits into from
Nov 1, 2023
Merged

TCP Dump #281

merged 16 commits into from
Nov 1, 2023

Conversation

peterbom
Copy link
Contributor

@peterbom peterbom commented Oct 26, 2023 •
edited
Loading

Resolves #246

Builds on @Tatsinnit's initial changes to create a debug pod and create captures from VS Code.

Example UX:
image

@peterbom peterbom requested a review from Tatsinnit October 26, 2023 01:30
@Tatsinnit Tatsinnit added the enhancement 🚀 New feature or request or improvements on existing code. label Oct 26, 2023
@peterbom peterbom force-pushed the feature/tcp-dump-pod-pb branch from a9a2bda to bd1e190 Compare October 26, 2023 03:02
@peterbom peterbom marked this pull request as ready for review October 26, 2023 04:38
Tatsinnit
Tatsinnit previously approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@Tatsinnit Tatsinnit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☕️👍 This is looks great! Any further updates could be done as s parate feature version upgrade to other careful thinking.

thanks you so much! let’s wait for Prabhas test, thanks prabha as well! (Fyi @sprab ) 🙏☕️

@Tatsinnit Tatsinnit requested a review from sprab October 27, 2023 08:17
@peterbom peterbom force-pushed the feature/tcp-dump-pod-pb branch from ca4aac7 to 7faa056 Compare October 30, 2023 02:43
sprab
sprab approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@sprab sprab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this in my own clusters and works like a charm.

@Tatsinnit Tatsinnit merged commit 0cbf90e into Azure:main Nov 1, 2023
4 checks passed
tejhan pushed a commit to tejhan/vscode-aks-tools that referenced this pull request Dec 4, 2024
@peterbom @Tatsinnit
TCP Dump (Azure#281)
225307b 
---------

Co-authored-by: Tatsinnit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sprab sprab sprab approved these changes

@Tatsinnit Tatsinnit Tatsinnit approved these changes

Assignees

@peterbom peterbom

Labels
enhancement 🚀 New feature or request or improvements on existing code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TCP Dump functionality x vscode
3 participants
@peterbom @Tatsinnit @sprab