Add state management to webviews #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsubramanianaks
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Thanks @peterbom for kind words. Without talking to you we wouldn't have found this state management issue. Looks good.
tejhan
pushed a commit
to tejhan/vscode-aks-tools
that referenced
this pull request
Dec 4, 2024
Co-authored-by: Hariharan Subramanian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Courtesy of @hsubramanianaks: this avoids webviews losing their state when they are hidden.
See: https://code.visualstudio.com/api/extension-guides/webview#retaincontextwhenhidden
The next step will be to work on an alternative approach to address the documented concern that "this has high memory overhead and should only be used when other persistence techniques will not work".