eslint fixes

src/auth/azureAuth.ts

@@ -1,18 +1,18 @@
+import { TokenCredential } from "@azure/core-auth";
+import { Environment } from "@azure/ms-rest-azure-env";
 import {
     AuthenticationSession,
-    Disposable as VsCodeDisposable,
     ProgressLocation,
     ProgressOptions,
     QuickPickItem,
+    Disposable as VsCodeDisposable,
     window,
 } from "vscode";
-import { AzureSessionProvider, ReadyAzureSessionProvider, Tenant, TokenInfo, isReady } from "./types";
-import { Environment } from "@azure/ms-rest-azure-env";
 import { getConfiguredAzureEnv } from "../commands/utils/config";
 import { Errorable, failed } from "../commands/utils/errorable";
-import { TokenCredential } from "@azure/core-auth";
 import { parseJson } from "../commands/utils/json";
 import { getSessionProvider } from "./azureSessionProvider";
+import { AzureSessionProvider, ReadyAzureSessionProvider, Tenant, TokenInfo, isReady } from "./types";
 
 export function getEnvironment(): Environment {
     return getConfiguredAzureEnv();
@@ -94,7 +94,7 @@ export function getTokenInfo(session: AuthenticationSession): Errorable<TokenInf
     try {
         jsonBody = Buffer.from(body, "base64").toString();
     } catch (e) {
-        return { succeeded: false, error: `Failed to decode JWT token body: ${body}` };
+        return { succeeded: false, error: `Failed to decode JWT token body: ${body} and error is: ${e}` };
     }
 
     const jwt = parseJson<Jwt>(jsonBody);

src/commands/draft/draftCommands.ts

@@ -1,33 +1,32 @@
+import { IActionContext } from "@microsoft/vscode-azext-utils";
+import { Octokit, RestEndpointMethodTypes } from "@octokit/rest";
+import path, { basename, extname, join } from "path";
 import {
     authentication,
+    AuthenticationSession,
     Extension,
     ExtensionContext,
-    WorkspaceFolder,
+    FileType,
+    Uri,
     window,
     workspace,
-    AuthenticationSession,
-    Uri,
-    FileType,
+    WorkspaceFolder,
 } from "vscode";
-import { DraftDockerfileDataProvider, DraftDockerfilePanel } from "../../panels/draft/DraftDockerfilePanel";
-import { getExtension } from "../utils/host";
-import { Errorable, failed, getErrorMessage, succeeded } from "../utils/errorable";
-import { getDraftBinaryPath } from "../utils/helper/draftBinaryDownload";
-import { DraftDeploymentDataProvider, DraftDeploymentPanel } from "../../panels/draft/DraftDeploymentPanel";
 import * as k8s from "vscode-kubernetes-tools-api";
-import { getDeploymentFilesToWrite } from "../utils/draft";
-import { getGitApi } from "../utils/git";
+import { getReadySessionProvider } from "../../auth/azureAuth";
+import { DraftDeploymentDataProvider, DraftDeploymentPanel } from "../../panels/draft/DraftDeploymentPanel";
+import { DraftDockerfileDataProvider, DraftDockerfilePanel } from "../../panels/draft/DraftDockerfilePanel";
 import { DraftWorkflowDataProvider, DraftWorkflowPanel } from "../../panels/draft/DraftWorkflowPanel";
-import { Octokit, RestEndpointMethodTypes } from "@octokit/rest";
 import { Remote } from "../../types/git";
-import { GitHubRepo } from "../../webview-contract/webviewDefinitions/draft/types";
 import { ExistingFile } from "../../webview-contract/webviewDefinitions/draft/draftWorkflow";
-import { basename, extname, join } from "path";
-import { getReadySessionProvider } from "../../auth/azureAuth";
-import { IActionContext } from "@microsoft/vscode-azext-utils";
-import { DraftCommandParamsType } from "./types";
+import { GitHubRepo } from "../../webview-contract/webviewDefinitions/draft/types";
 import { getAksClusterTreeNode } from "../utils/clusters";
-import path from "path";
+import { getDeploymentFilesToWrite } from "../utils/draft";
+import { Errorable, failed, getErrorMessage, succeeded } from "../utils/errorable";
+import { getGitApi } from "../utils/git";
+import { getDraftBinaryPath } from "../utils/helper/draftBinaryDownload";
+import { getExtension } from "../utils/host";
+import { DraftCommandParamsType } from "./types";
 
 export async function draftDockerfile(_context: IActionContext, target: unknown): Promise<void> {
     const params = getDraftDockerfileParams(target);
@@ -151,7 +150,7 @@ export async function draftWorkflow(_context: IActionContext, target: unknown):
                     path: join(".github", "workflows", name),
                 };
             });
-    } catch (e) {
+    } catch {
         // If the directory doesn't exist, that's fine - it just means there will be no existing workflow files.
     }
 
@@ -236,7 +235,7 @@ async function getRepo(octokit: Octokit, remote: Remote): Promise<GitHubRepo | n
     let response: RestEndpointMethodTypes["repos"]["get"]["response"];
     try {
         response = await octokit.repos.get({ owner, repo });
-    } catch (e) {
+    } catch {
         return null;
     }
 

src/commands/utils/config.ts

@@ -1,11 +1,11 @@
-import * as vscode from "vscode";
-import { combine, failed, Errorable } from "./errorable";
-import { KubeloginConfig, KustomizeConfig } from "../periscope/models/config";
+import { Environment, EnvironmentParameters } from "@azure/ms-rest-azure-env";
 import * as semver from "semver";
+import * as vscode from "vscode";
 import { CommandCategory, PresetCommand } from "../../webview-contract/webviewDefinitions/kubectl";
+import { KubeloginConfig, KustomizeConfig } from "../periscope/models/config";
 import { RetinaDownloadConfig } from "../periscope/models/RetinaDownloadConfig";
+import { combine, Errorable, failed } from "./errorable";
 import { isObject } from "./runtimeTypes";
-import { Environment, EnvironmentParameters } from "@azure/ms-rest-azure-env";
 
 export function getConfiguredAzureEnv(): Environment {
     // See:
@@ -52,7 +52,7 @@ export function getFilteredSubscriptions(): SubscriptionFilter[] {
             values = vscode.workspace.getConfiguration("azure").get<string[]>("resourceFilter", []);
         }
         return values.map(asSubscriptionFilter).filter((v) => v !== null) as SubscriptionFilter[];
-    } catch (e) {
+    } catch {
         return [];
     }
 }
@@ -61,7 +61,7 @@ function asSubscriptionFilter(value: string): SubscriptionFilter | null {
     try {
         const parts = value.split("/");
         return { tenantId: parts[0], subscriptionId: parts[1] };
-    } catch (e) {
+    } catch {
         return null;
     }
 }

src/commands/utils/detectors.ts

@@ -1,18 +1,18 @@
-import { Errorable, combine, failed, getErrorMessage } from "./errorable";
-import { AksClusterTreeNode } from "../../tree/aksClusterTreeItem";
+import { Environment } from "@azure/ms-rest-azure-env";
 import * as fs from "fs";
 import * as path from "path";
+import { dirSync } from "tmp";
+import { ReadyAzureSessionProvider } from "../../auth/types";
+import { AksClusterTreeNode } from "../../tree/aksClusterTreeItem";
 import {
     ARMResponse,
     CategoryDetectorARMResponse,
     SingleDetectorARMResponse,
     isCategoryDataset,
 } from "../../webview-contract/webviewDefinitions/detector";
-import { dirSync } from "tmp";
-import { Environment } from "@azure/ms-rest-azure-env";
-import { getPortalResourceUrl } from "./env";
 import { getResourceManagementClient } from "./arm";
-import { ReadyAzureSessionProvider } from "../../auth/types";
+import { getPortalResourceUrl } from "./env";
+import { Errorable, combine, failed, getErrorMessage } from "./errorable";
 
 /**
  * Can be used to store the JSON responses for a collection of category detectors and all their child detectors.
@@ -76,7 +76,10 @@ export async function getDetectorListData(
     } catch (err) {
         // This would be unexpected even in the event of network failure, because the individual promises handle
         // their own errors.
-        return { succeeded: false, error: `Failed to retrieve detector data for ${categoryDetector.name}` };
+        return {
+            succeeded: false,
+            error: `Failed to retrieve detector data for ${categoryDetector.name} and error is ${err}`,
+        };
     }
 
     return combine(results);

src/webview-contract/webviewDefinitions/inspektorGadget.ts

@@ -1,6 +1,6 @@
 import { WebviewDefinition } from "../webviewTypes";
 
-export interface InitialState {}
+export type InitialState = object;
 
 export interface GadgetVersion {
     client: string;