Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Terraform sample for a Quickstart for Azure Private Link that creates a private endpoint for an Azure SQL server #312

Merged
merged 5 commits into from
Feb 21, 2024
Merged

New Terraform sample for a Quickstart for Azure Private Link that creates a private endpoint for an Azure SQL server #312

merged 5 commits into from
Feb 21, 2024

Conversation

asudbring
Copy link
Contributor

No description provided.

lonegunmanb
lonegunmanb requested changes Feb 2, 2024
View reviewed changes
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @asudbring for opening this pr! One review comment to solve and one question, then we're good to kick off the e2e.

quickstart/201-private-link-sql-database/outputs.tf Show resolved Hide resolved
@asudbring
Copy link
Contributor Author

Thanks @asudbring for opening this pr! One review comment to solve and one question, then we're good to kick off the e2e.
@lonegunmanb Can this be merged? Thanks!

@asudbring
Copy link
Contributor Author

@lonegunmanb
Fixed error in workflow by adding the requested provider.

@asudbring
Copy link
Contributor Author

@TomArcherMsft can you approve workflow to see if the code is fixed? Thank you!!

@asudbring
Copy link
Contributor Author

@lonegunmanb
Can you kick off the workflow? Need to make sure everything is ok so this can get merged.

Thanks!

@asudbring
Copy link
Contributor Author

@lonegunmanb @TomArcherMsft
Looks like workflow completed successfully and no errors. Should be ready to merge.

Thanks!
allen

lonegunmanb
lonegunmanb requested changes Feb 20, 2024
View reviewed changes
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @asudbring thanks for updating the pr, still got a question about output nat_gateway.

quickstart/201-private-link-sql-database/outputs.tf Show resolved Hide resolved
lonegunmanb
lonegunmanb approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @asudbring for the update, LGTM!

@lonegunmanb lonegunmanb merged commit 89f82a6 into Azure:master Feb 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomArcherMsft TomArcherMsft TomArcherMsft left review comments

@lonegunmanb lonegunmanb lonegunmanb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asudbring @lonegunmanb @TomArcherMsft