-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Terraform code for deploying Azure Managed Lustre file system #258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pauljewellmsft Thanks for the PR! There are only a handful of small issues to address.
Thanks for the comments, @TomArcherMsft. I'll incorporate changes with my next commit. One additional question - for naming of resources such as virtual network, subnet, etc., is it preferred to create a variable with a default of "", and randomly generate a string if it's blank? Similar to what's done for Key Vault? Or do we prefer a different approach? thx |
Please do follow the KV example. |
@TomArcherMsft Review feedback is incorporated into the PR. Thanks! |
@pauljewellmsft Thanks! I've run the e2e tests and they seem to be successful. @lonegunmanb , @grayzu , @stemaMSFT Please review. |
LGTM! |
No description provided.