Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Terraform code for deploying Azure Managed Lustre file system #258

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

pauljewellmsft
Copy link
Contributor

No description provided.

Copy link
Collaborator

@TomArcherMsft TomArcherMsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pauljewellmsft Thanks for the PR! There are only a handful of small issues to address.

quickstart/101-managed-lustre-create-filesystem/README.md Outdated Show resolved Hide resolved
quickstart/101-managed-lustre-create-filesystem/README.md Outdated Show resolved Hide resolved
quickstart/101-managed-lustre-create-filesystem/main.tf Outdated Show resolved Hide resolved
quickstart/101-managed-lustre-create-filesystem/main.tf Outdated Show resolved Hide resolved
@pauljewellmsft
Copy link
Contributor Author

pauljewellmsft commented Oct 16, 2023

Thanks for the comments, @TomArcherMsft. I'll incorporate changes with my next commit.

One additional question - for naming of resources such as virtual network, subnet, etc., is it preferred to create a variable with a default of "", and randomly generate a string if it's blank? Similar to what's done for Key Vault? Or do we prefer a different approach? thx

@TomArcherMsft
Copy link
Collaborator

Thanks for the comments, @TomArcherMsft. I'll incorporate changes with my next commit.

One additional question - for naming of resources such as virtual network, subnet, etc., is it preferred to create a variable with a default of "", and randomly generate a string if it's blank? Similar to what's done for Key Vault? Or do we prefer a different approach? thx

Please do follow the KV example.

@pauljewellmsft
Copy link
Contributor Author

@TomArcherMsft Review feedback is incorporated into the PR. Thanks!

@pauljewellmsft pauljewellmsft temporarily deployed to acctests October 16, 2023 19:31 — with GitHub Actions Inactive
@TomArcherMsft
Copy link
Collaborator

@pauljewellmsft Thanks! I've run the e2e tests and they seem to be successful. @lonegunmanb , @grayzu , @stemaMSFT Please review.

@stemaMSFT
Copy link
Member

LGTM!

@stemaMSFT stemaMSFT merged commit 1d14811 into Azure:master Oct 16, 2023
3 checks passed
@pauljewellmsft pauljewellmsft deleted the amlfs-sample branch October 16, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants