fw quickstart with multiple addresses #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomArcherMsft
requested changes
Oct 2, 2023
lonegunmanb
requested changes
Oct 2, 2023
|
@lonegunmanb @TomArcherMsft I believe this PR should be ready for merge. let me know if there is anything else that I missed. |
TomArcherMsft
requested changes
Oct 5, 2023
|
@lonegunmanb anything thing else that needs to be changed? |
|
Hi @cshea-msft thanks for the update, we're facing the same issue as I've described in #252 , would you please rebase this pr with the latest main branch and force push again? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
creating a firewall with multiple address quickstart in Terraform, there is already bicep and arm quickstart published. PG asked for Terraform quickstart.
https://learn.microsoft.com/en-us/azure/firewall/quick-create-multiple-ip-bicep?tabs=CLI