-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
firewall quickstart with ipgroups #253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Only a few minor issues for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cshea15 for opening this pr! Some review comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than needing to implement the SSH, only a few typos.
@lonegunmanb anything thing else that needs to be changed? |
Hi @cshea-msft thanks for the update, we're facing the same issue as I've described in #252 , would you please rebase this pr with the latest main branch and force push again? Thanks! |
Creating another azure firewall quickstarts with ipgroups. There is a Bicep and ARM template quickstart for this scenario but not for Terraform.
https://learn.microsoft.com/en-us/azure/firewall/quick-create-ipgroup-bicep?tabs=CLI