feat: initial scaffold for new linting #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lonegunmanb please see this scaffold - is this what you need? |
kewalaka
reviewed
Dec 8, 2023
| - name: terraform init | ||
| run: terraform init | ||
| - name: terraform fmt check | ||
| run: exit 0 |
There was a problem hiding this comment.
i'm curious why the run commands in this file are "exit 0" ?
There was a problem hiding this comment.
This is so @lonegunmanb can update this branch with the actual tasks. He will use the docker container approach pioneered with TFVM.
lonegunmanb
reviewed
Dec 11, 2023
lonegunmanb
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
@matt-FFFFFF I think I'm ready to continue the work based on this branch, except one comment.
|
I'm closing this pr in favor of #53. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to integrate TFVM pipeline