add missing interfaces

[kewalaka]

No description provided.

[kewalaka]

i thought i had included all the AVM interfaces, but hadn't, so here they are.

@matt-FFFFFF I think it makes sense to include them all and remove them if not needed, to encourage making sure the required interfaces are implement. I've added a couple arbitrary descriptions missing from the AVM website.

[segraef]

lgtm, let's wait for @matt-FFFFFF

[kewalaka]

@segraef agreed, this one and the 'avmfix' one I raised more for discussion. lonegunmanb has a number of cool actions that would be nice to bring into the linting and general checks for AVM - such as the breaking change detection, and avmfix tool.

the one I think that is worth fixing and is non-controversial is #49, that's a simple bug.

[matt-FFFFFF]

@kewalaka please can you look at my comments on #49

then we can review this and merge - thanks 😄

[kewalaka]

hi @matt-FFFFFF - #49 updated and merged in.

Before merging this, any views on the avmfix version I posted #50, specifically whether it is worth having a separate variable file for the "avm" interfaces (since avmfix will reorder them, mixing up resource specific & avm-generic concerns).

alternatively, I wonder if variables.tf should just be for the AVM interfaces, whereas the parent goes in their own, like the children do, e.g. variables.keyvault.tf & variables.secrets.tf.

(edit, with more consideration, i think I prefer the last suggestion vs what I posted in #50)