Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #110

Merged
merged 1 commit into from
May 6, 2024
Merged

Update CODEOWNERS #110

merged 1 commit into from
May 6, 2024

Conversation

mbilalamjad
Copy link
Collaborator

Per our documentation, the avm-core-team-technical is no longer being asked to be added to repo with admin or write permissions

Instead, we are now requesting every module owner to add avm-core-team-technical-terraform with admin permissions.

Currently codeowners file on all TF repos are throwing an error as this team was replaced on all repos with the other team

Therefore, updating the codeowners file to reflect this change and fix the issue.

Description

Type of Change

  • Non-module change (e.g. CI/CD, documentation, etc.)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in locals.version.tf.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in locals.version.tf.json.
    • Breaking changes and I have bumped the MAJOR version in locals.version.tf.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • I did run all pre-commit checks

Per our documentation, the avm-core-team-technical is no longer being asked to be added to repo with admin or write permissions

Instead, we are now requesting every module owner to add avm-core-team-technical-terraform with admin permissions.

Currently codeowners file on all TF repos are throwing an error as this team was replaced on all repos with the other team

Therefore, updating the codeowners file to reflect this change and fix the issue.

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Note

This label was added as per ITA06.

@mbilalamjad mbilalamjad merged commit c5943f7 into main May 6, 2024
9 checks passed
@mbilalamjad mbilalamjad deleted the codeowners-team-update branch May 6, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants