-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alignment with AVM specification & grept-apply requirements #106
Merged
matt-FFFFFF
merged 5 commits into
Azure:main
from
kewalaka:fix/corrections-from-linting
Apr 17, 2024
Merged
alignment with AVM specification & grept-apply requirements #106
matt-FFFFFF
merged 5 commits into
Azure:main
from
kewalaka:fix/corrections-from-linting
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kewalaka
changed the title
Fix/corrections from linting
alignment with AVM specification & grept-apply requirements
Apr 11, 2024
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Note This label was added as per ITA06. |
kewalaka
added a commit
to kewalaka/terraform-azurerm-avm-res-sql-server-1
that referenced
this pull request
Apr 11, 2024
11 tasks
this also includes the fix for the location / "evil data source" 😅 |
segraef
reviewed
Apr 11, 2024
jaredfholgate
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
matt-FFFFFF
approved these changes
Apr 17, 2024
mbilalamjad
pushed a commit
to Azure/terraform-azurerm-avm-res-sql-server
that referenced
this pull request
Apr 24, 2024
* fix: grept apply (#3) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: AVM template alignment * this re-aligns the template with fixes based on Azure/terraform-azurerm-avm-template#106 --------- Co-authored-by: Matt White <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This re-aligns the template with changes to the docs / AVM specification & fixes reported by grept-apply.
There are some existing PRs which repeat the same functionality, adding tags & new files to .gitignore based on grept-apply outputs, I believe this is more comprehensive (cc @jaredfholgate for a check)
It introduces the fix for private endpoints conflicting with Azure Policy based on the spec, with some corrections raised with @matt-FFFFFF here; Azure/terraform-azurerm-avm-res-keyvault-vault#32 (comment)
I've used this as the starting point for the SQL Module that I'm preparing to post, as you can't properly lint this code due to things like TODOs.
-->
Type of Change
locals.version.tf.json
:locals.version.tf.json
.locals.version.tf.json
.Checklist