Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alignment with AVM specification & grept-apply requirements #106

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

kewalaka
Copy link
Contributor

Description

This re-aligns the template with changes to the docs / AVM specification & fixes reported by grept-apply.

There are some existing PRs which repeat the same functionality, adding tags & new files to .gitignore based on grept-apply outputs, I believe this is more comprehensive (cc @jaredfholgate for a check)

It introduces the fix for private endpoints conflicting with Azure Policy based on the spec, with some corrections raised with @matt-FFFFFF here; Azure/terraform-azurerm-avm-res-keyvault-vault#32 (comment)

I've used this as the starting point for the SQL Module that I'm preparing to post, as you can't properly lint this code due to things like TODOs.

-->

Type of Change

  • Non-module change (e.g. CI/CD, documentation, etc.)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in locals.version.tf.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in locals.version.tf.json.
    • Breaking changes and I have bumped the MAJOR version in locals.version.tf.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change (there are some minors - noted above).
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • I did run all pre-commit checks

@kewalaka kewalaka changed the title Fix/corrections from linting alignment with AVM specification & grept-apply requirements Apr 11, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Note

This label was added as per ITA06.

kewalaka added a commit to kewalaka/terraform-azurerm-avm-res-sql-server-1 that referenced this pull request Apr 11, 2024
@kewalaka
Copy link
Contributor Author

this also includes the fix for the location / "evil data source" 😅

.gitignore Show resolved Hide resolved
Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matt-FFFFFF matt-FFFFFF merged commit ee416f4 into Azure:main Apr 17, 2024
9 checks passed
mbilalamjad pushed a commit to Azure/terraform-azurerm-avm-res-sql-server that referenced this pull request Apr 24, 2024
* fix: grept apply (#3)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: AVM template alignment

* this re-aligns the template with fixes based on Azure/terraform-azurerm-avm-template#106

---------

Co-authored-by: Matt White <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants